Label session adapters in the output of zeek -NN

src/analyzer/Component.cc

@@ -8,8 +8,9 @@
 
 namespace zeek::analyzer {
 
-Component::Component(const std::string& name, factory_callback arg_factory, Tag::subtype_t arg_subtype, bool arg_enabled, bool arg_partial)
+Component::Component(const std::string& name, factory_callback arg_factory, Tag::subtype_t arg_subtype,
-	: plugin::Component(plugin::component::ANALYZER, name),
+                     bool arg_enabled, bool arg_partial, bool arg_adapter)
+	: plugin::Component(arg_adapter ? plugin::component::SESSION_ADAPTER : plugin::component::ANALYZER, name),
 	  plugin::TaggedComponent<analyzer::Tag>(arg_subtype)
 	{
 	factory = arg_factory;

src/analyzer/Component.h

@@ -53,12 +53,16 @@ public:
 	 * manager, including from script-land.
 	 *
 	 * @param partial If true, the analyzer can deal with payload from
-	 * partial connections, i.e., when Bro enters the stream mid-way
+	 * partial connections, i.e., when Zeek enters the stream mid-way
 	 * after not seeing the beginning. Note that handling of partial
 	 * connections has generally not seen much testing yet as virtually
 	 * no existing analyzer supports it.
+	 *
+	 * @param adapter If true, this analyzer is a session adapter from
+	 * the packet analyzer framework.
 	 */
-	Component(const std::string& name, factory_callback factory, Tag::subtype_t subtype = 0, bool enabled = true, bool partial = false);
+	Component(const std::string& name, factory_callback factory, Tag::subtype_t subtype = 0,
+	          bool enabled = true, bool partial = false, bool adapter = false);
 
 	/**
 	 * Destructor.

src/packet_analysis/protocol/icmp/ICMPSessionAdapter.h

@@ -14,11 +14,6 @@ public:
 	ICMPSessionAdapter(Connection* conn) :
 		IP::SessionAdapter("ICMP", conn) { }
 
-	static zeek::analyzer::Analyzer* Instantiate(Connection* conn)
-		{
-		return new ICMPSessionAdapter(conn);
-		}
-
 	void AddExtraAnalyzers(Connection* conn) override;
 	void UpdateConnVal(RecordVal* conn_val) override;
 	void UpdateEndpointVal(const ValPtr& endp, bool is_orig);

src/packet_analysis/protocol/icmp/Plugin.cc

@@ -14,8 +14,7 @@ public:
 		{
 		AddComponent(new zeek::packet_analysis::Component("ICMP",
 		                 zeek::packet_analysis::ICMP::ICMPAnalyzer::Instantiate));
-		AddComponent(new zeek::analyzer::Component("ICMP",
+		AddComponent(new zeek::analyzer::Component("ICMP", nullptr, 0, true, false, true));
-		                 zeek::packet_analysis::ICMP::ICMPSessionAdapter::Instantiate));
 
 		zeek::plugin::Configuration config;
 		config.name = "Zeek::ICMP";

src/packet_analysis/protocol/tcp/Plugin.cc

@@ -14,8 +14,7 @@ public:
 		{
 		AddComponent(new zeek::packet_analysis::Component("TCP",
 		                 zeek::packet_analysis::TCP::TCPAnalyzer::Instantiate));
-		AddComponent(new zeek::analyzer::Component("TCP",
+		AddComponent(new zeek::analyzer::Component("TCP", nullptr, 0, true, false, true));
-		                 zeek::packet_analysis::TCP::TCPSessionAdapter::Instantiate));
 
 		zeek::plugin::Configuration config;
 		config.name = "Zeek::TCP_PKT";

src/packet_analysis/protocol/tcp/TCPSessionAdapter.h

@@ -69,9 +69,6 @@ public:
 	// From Analyzer.h
 	void UpdateConnVal(RecordVal *conn_val) override;
 
-	static analyzer::Analyzer* Instantiate(Connection* conn)
-		{ return new TCPSessionAdapter(conn); }
-
 	void AddExtraAnalyzers(Connection* conn) override;
 
 protected:

src/packet_analysis/protocol/udp/Plugin.cc

@@ -14,8 +14,7 @@ public:
 		{
 		AddComponent(new zeek::packet_analysis::Component("UDP",
 		                 zeek::packet_analysis::UDP::UDPAnalyzer::Instantiate));
-		AddComponent(new zeek::analyzer::Component("UDP",
+		AddComponent(new zeek::analyzer::Component("UDP", nullptr, 0, true, false, true));
-		                 zeek::packet_analysis::UDP::UDPSessionAdapter::Instantiate));
 
 		zeek::plugin::Configuration config;
 		config.name = "Zeek::UDP";

src/packet_analysis/protocol/udp/UDPSessionAdapter.h

@@ -13,11 +13,6 @@ public:
 	UDPSessionAdapter(Connection* conn) :
 		IP::SessionAdapter("UDP", conn) { }
 
-	static zeek::analyzer::Analyzer* Instantiate(Connection* conn)
-		{
-		return new UDPSessionAdapter(conn);
-		}
-
 	void AddExtraAnalyzers(Connection* conn) override;
 	void UpdateConnVal(RecordVal* conn_val) override;
 

src/plugin/Component.cc

@@ -66,6 +66,10 @@ void Component::Describe(ODesc* d) const
 		d->Add("Packet Dumper");
 		break;
 
+	case component::SESSION_ADAPTER:
+		d->Add("Session Adapter");
+		break;
+
 	default:
 		reporter->InternalWarning("unknown component type in plugin::Component::Describe");
 		d->Add("<unknown component type>");

src/plugin/Component.h

@@ -23,7 +23,8 @@ enum Type {
 	FILE_ANALYZER,    /// A file analyzer.
 	IOSOURCE,  /// An I/O source, excluding packet sources.
 	PKTSRC,	   /// A packet source.
-	PKTDUMPER  /// A packet dumper.
+	PKTDUMPER, /// A packet dumper.
+	SESSION_ADAPTER,	/// A session adapter analyzer.
 	};
 
 } // namespace component