A fatal error, especially in DEBUG, should result in a core.

This issue is especially helpful in the case of the Val::CONVERTER error and having:

"fatal error in <no location>: Val::CONVERTER ..."

Nebulous error and sans location, it is extremely hard to figure out the culprit. Thus, if Bro is built DEBUG, fatal should provide a core.

This subtle change prevents having to change FatalErrors to FatalErrorWithCore everywhere.

src/Reporter.cc

@@ -88,7 +88,11 @@ void Reporter::FatalError(const char* fmt, ...)
 	va_end(ap);
 
 	set_processing_status("TERMINATED", "fatal_error");
+#ifdef DEBUG
+	abort();
+#else
 	exit(1);
+#endif // DEBUG
 	}
 
 void Reporter::FatalErrorWithCore(const char* fmt, ...)
@@ -393,4 +397,3 @@ void Reporter::DoLog(const char* prefix, EventHandlerPtr event, FILE* out,
 	if ( alloced )
 		free(alloced);
 	}
-