Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 06:38:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

cluster/websocket: Fix null deref at WebSocket server shutdown

Browse source 
WebSocket clients that connected with the wrong URL do not have
a backend attached. If a dispatcher is terminated while these
clients are still connected, a null deref would happen.

This was found while running all cluster/websocket tests in a loop
for a long time, tickling a segfault during the bad-url test.
This commit is contained in:
Arne Welzel 2025-03-14 15:37:22 +01:00
parent 888af244b2
commit 26441e0c24
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/cluster/websocket/WebSocket.cc
View file

@ -231,7 +231,9 @@ void WebSocketEventDispatcher::Terminate() {
wsc->getRemotePort());
QueueReply(WebSocketCloseReply{wsc, 1001, "Terminating"});
backend->Terminate();
if ( backend )
backend->Terminate();
}
clients.clear();