Reorganize some pointer handling

This commit is contained in:
Tim Wojtulewicz 2020-07-13 19:01:51 -07:00
parent 94ec639bfb
commit 27fea2b218

View file

@ -113,56 +113,52 @@ void Manager::DumpDebug()
bool Manager::EnableAnalyzer(const Tag& tag) bool Manager::EnableAnalyzer(const Tag& tag)
{ {
Component* p = Lookup(tag); if ( Component* p = Lookup(tag) )
{
if ( ! p )
return false;
DBG_LOG(DBG_PACKET_ANALYSIS, "Enabling analyzer %s", p->Name().c_str()); DBG_LOG(DBG_PACKET_ANALYSIS, "Enabling analyzer %s", p->Name().c_str());
p->SetEnabled(true); p->SetEnabled(true);
return true; return true;
} }
return false;
}
bool Manager::EnableAnalyzer(EnumVal* val) bool Manager::EnableAnalyzer(EnumVal* val)
{ {
Component* p = Lookup(val); if ( Component* p = Lookup(val) )
{
if ( ! p )
return false;
DBG_LOG(DBG_PACKET_ANALYSIS, "Enabling analyzer %s", p->Name().c_str()); DBG_LOG(DBG_PACKET_ANALYSIS, "Enabling analyzer %s", p->Name().c_str());
p->SetEnabled(true); p->SetEnabled(true);
return true; return true;
} }
return false;
}
bool Manager::DisableAnalyzer(const Tag& tag) bool Manager::DisableAnalyzer(const Tag& tag)
{ {
Component* p = Lookup(tag); if ( Component* p = Lookup(tag) )
{
if ( ! p )
return false;
DBG_LOG(DBG_PACKET_ANALYSIS, "Disabling analyzer %s", p->Name().c_str()); DBG_LOG(DBG_PACKET_ANALYSIS, "Disabling analyzer %s", p->Name().c_str());
p->SetEnabled(false); p->SetEnabled(false);
return true; return true;
} }
return false;
}
bool Manager::DisableAnalyzer(EnumVal* val) bool Manager::DisableAnalyzer(EnumVal* val)
{ {
Component* p = Lookup(val); if ( Component* p = Lookup(val) )
{
if ( ! p )
return false;
DBG_LOG(DBG_PACKET_ANALYSIS, "Disabling analyzer %s", p->Name().c_str()); DBG_LOG(DBG_PACKET_ANALYSIS, "Disabling analyzer %s", p->Name().c_str());
p->SetEnabled(false); p->SetEnabled(false);
return true; return true;
} }
return false;
}
void Manager::DisableAllAnalyzers() void Manager::DisableAllAnalyzers()
{ {
DBG_LOG(DBG_PACKET_ANALYSIS, "Disabling all analyzers"); DBG_LOG(DBG_PACKET_ANALYSIS, "Disabling all analyzers");
@ -182,22 +178,18 @@ bool Manager::IsEnabled(Tag tag)
if ( ! tag ) if ( ! tag )
return false; return false;
Component* p = Lookup(tag); if ( Component* p = Lookup(tag) )
if ( ! p )
return false;
return p->Enabled(); return p->Enabled();
return false;
} }
bool Manager::IsEnabled(EnumVal* val) bool Manager::IsEnabled(EnumVal* val)
{ {
Component* p = Lookup(val); if ( Component* p = Lookup(val) )
if ( ! p )
return false;
return p->Enabled(); return p->Enabled();
return false;
} }
Analyzer* Manager::InstantiateAnalyzer(const Tag& tag) Analyzer* Manager::InstantiateAnalyzer(const Tag& tag)