Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-17 14:08:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix a swath of AUTO_CAUSES_COPY issues reported by Coverity

Browse source
This commit is contained in:
Tim Wojtulewicz 2022-08-15 09:45:46 -07:00
parent f631551ffb
commit 2abc82722f
7 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/script_opt/CPP/Driver.cc
View file

@ -314,7 +314,7 @@ void CPPCompile::GenEpilog()
GenCPPDynStmt();
NL();
for ( auto gi : all_global_info )
for ( const auto& gi : all_global_info )
gi->GenerateInitializers(this);
NL();
@ -449,7 +449,7 @@ void CPPCompile::GenFinishInit()
max_cohort = std::max(max_cohort, gi->MaxCohort());
for ( auto c = 0; c <= max_cohort; ++c )
for ( auto gi : all_global_info )
for ( const auto& gi : all_global_info )
if ( gi->CohortSize(c) > 0 )
Emit("%s.InitializeCohort(&im, %s);", gi->InitializersName(), Fmt(c));

2
src/script_opt/Stmt.cc
View file

@ -895,7 +895,7 @@ StmtPtr InitStmt::Duplicate()
// Need to duplicate the initializer list since later reductions
// can modify it in place.
std::vector<IDPtr> new_inits;
for ( auto id : inits )
for ( const auto& id : inits )
new_inits.push_back(id);
return SetSucc(new InitStmt(new_inits));

2
src/script_opt/UseDefs.cc
View file

@ -83,7 +83,7 @@ bool UseDefs::RemoveUnused(int iter)
const auto& inits = init->Inits();
std::vector<IDPtr> used_ids;
for ( auto id : inits )
for ( const auto& id : inits )
if ( is_atomic_type(id->GetType()) || ! CheckIfUnused(s, id.get(), false) )
used_ids.emplace_back(id);

2
src/script_opt/ZAM/Driver.cc
View file

@ -370,7 +370,7 @@ void ZAMCompiler::Dump()
if ( remapped_frame )
printf("Original frame for %s:\n", func->Name());
for ( auto elem : frame_layout1 )
for ( const auto& elem : frame_layout1 )
printf("frame[%d] = %s\n", elem.second, elem.first->Name());
if ( remapped_frame )