mirror of
https://github.com/zeek/zeek.git
synced 2025-10-06 00:28:21 +00:00
Zeek Table<->Brokerstore: cleanup, documentation, small fixes
This commit adds script/c++ documentation and fixes a few loose ends. It also adds tests for corner cases and massively improves error messages. This also actually introduces type-compatibility checking and introduces a new attribute that lets a user override this if they really know what they are doing. I am not quite sure if we should really let that stay in - but it can be very convenient to have this functionality. One test is continuing to fail - the expiry test is very flaky. This is, I think, caused by delays of the broker store forwarding. I am unsure if we can actually do anything about that.
This commit is contained in:
parent
67917b83aa
commit
2b2a40f49c
26 changed files with 271 additions and 53 deletions
|
@ -1515,7 +1515,7 @@ void TableVal::SetAttrs(detail::AttributesPtr a)
|
|||
change_func = cf->GetExpr();
|
||||
|
||||
auto bs = attrs->Find(zeek::detail::ATTR_BROKER_STORE);
|
||||
if ( bs && broker_store.empty() ) // this does not mesh well with being updated several times
|
||||
if ( bs && broker_store.empty() )
|
||||
{
|
||||
IntrusivePtr<Val> c = bs->GetExpr()->Eval(nullptr);
|
||||
assert(c);
|
||||
|
@ -2181,8 +2181,6 @@ void TableVal::SendToStore(const Val* index, const TableEntryVal* new_entry_val,
|
|||
index_val = index;
|
||||
}
|
||||
|
||||
// FIXME: switch back to just storing tables directly in the broker store?
|
||||
// me which store a change came from - and this still seems to be missing from the store_events. (Or I am blind).
|
||||
auto broker_index = bro_broker::val_to_data(index_val);
|
||||
|
||||
if ( ! broker_index )
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue