Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-06 08:38:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

GH-219: fix |x| operator int overflow / floating point type inconsistency

Browse source 
When 'x' is an integral arithmetic expression, it's now coerced to
yield a signed integer before taking the absolute value of it to
prevent the common issue of unsigned integer overflow/wraparound for
values below zero.

Using a time or interval value/expression for 'x' now also yields a
time or interval, respective, from the |x| operation instead of
a double.
This commit is contained in:
Jon Siwek 2019-01-22 16:42:40 -06:00
parent bebc0fba6d
commit 3256ac7c49
8 changed files with 21 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Val.cc
View file

@ -425,7 +425,7 @@ Val* Val::SizeVal() const
return val_mgr->GetCount(val.uint_val);
case TYPE_INTERNAL_DOUBLE:
return new Val(fabs(val.double_val), TYPE_DOUBLE);
return new Val(fabs(val.double_val), type->Tag());
case TYPE_INTERNAL_OTHER:
if ( type->Tag() == TYPE_FUNC )