Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix potential memory leak in Kerberos scripts

Browse source 
Reported by Maksim Shudrak.
This commit is contained in:
Jon Siwek 2018-09-10 18:06:07 -05:00
parent 7e26bfe07f
commit 34d0cf886c
3 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/base/protocols/krb/main.bro
View file

@ -140,6 +140,7 @@ event krb_as_request(c: connection, msg: KDC_Request) &priority=5
c$krb$request_type = "AS"; c$krb$request_type = "AS";
c$krb$client = fmt("%s/%s", msg?$client_name ? msg$client_name : "", msg$service_realm); c$krb$client = fmt("%s/%s", msg?$client_name ? msg$client_name : "", msg$service_realm);
if ( msg?$service_name )
c$krb$service = msg$service_name; c$krb$service = msg$service_name;
if ( msg?$from ) if ( msg?$from )
@ -183,6 +184,7 @@ event krb_tgs_request(c: connection, msg: KDC_Request) &priority=5
return; return;
c$krb$request_type = "TGS"; c$krb$request_type = "TGS";
if ( msg?$service_name )
c$krb$service = msg$service_name; c$krb$service = msg$service_name;
if ( msg?$from ) if ( msg?$from )
c$krb$from = msg$from; c$krb$from = msg$from;

BIN
testing/btest/Traces/krb/optional-service-name.pcap Executable file
View file

Binary file not shown.

8
testing/btest/core/leaks/krb-service-name.test Normal file
View file

@ -0,0 +1,8 @@
# Needs perftools support.
#
# @TEST-REQUIRES: bro --help 2>&1 | grep -q mem-leaks
#
# @TEST-GROUP: leaks
#
# @TEST-EXEC: HEAP_CHECK_DUMP_DIRECTORY=. HEAPCHECK=local btest-bg-run bro bro -m -r $TRACES/krb/optional-service-name.pcap
# @TEST-EXEC: btest-bg-wait 60