Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-04 07:38:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Mark a few clang-tidy findings as false-positive

Browse source
This commit is contained in:
Tim Wojtulewicz 2020-02-03 17:57:22 -05:00
parent d23b15c08f
commit 3572e38ec2
4 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/CompHash.cc
View file

@ -918,6 +918,10 @@ const char* CompositeHash::RecoverOneVal(const HashKey* k, const char* kp0,
kp = RecoverOneVal(k, kp, k_end,
rt->FieldType(i), v, optional);
// An earlier call to reporter->InternalError would have called abort() and broken the
// call tree that clang-tidy is relying on to get the error described.
// NOLINTNEXTLINE(clang-analyzer-core.uninitialized.Branch)
if ( ! (v || optional) )
{
reporter->InternalError("didn't recover expected number of fields from HashKey");