ARP: remove unnecessary variables and add testcase

BIT-1573 #close
This commit is contained in:
Johanna Amann 2016-04-27 06:51:04 -07:00
parent e9a87566ef
commit 3a70289e91
5 changed files with 15 additions and 7 deletions

View file

@ -10,9 +10,6 @@ using namespace analyzer::arp;
ARP_Analyzer::ARP_Analyzer() ARP_Analyzer::ARP_Analyzer()
{ {
bad_arp = internal_handler("bad_arp");
arp_request = internal_handler("arp_request");
arp_reply = internal_handler("arp_reply");
} }
ARP_Analyzer::~ARP_Analyzer() ARP_Analyzer::~ARP_Analyzer()

View file

@ -50,10 +50,6 @@ protected:
StringVal* EthAddrToStr(const u_char* addr); StringVal* EthAddrToStr(const u_char* addr);
void BadARP(const struct arp_pkthdr* hdr, const char* string); void BadARP(const struct arp_pkthdr* hdr, const char* string);
void Corrupted(const char* string); void Corrupted(const char* string);
EventHandlerPtr arp_corrupted_packet;
EventHandlerPtr arp_request;
EventHandlerPtr arp_reply;
}; };
} } // namespace analyzer::* } } // namespace analyzer::*

View file

@ -0,0 +1,2 @@
78:31:c1:c6:3f:c2, ff:ff:ff:ff:ff:ff, 10.0.0.2, 78:31:c1:c6:3f:c2, 10.0.0.1, 00:00:00:00:00:00
f8:ed:a5:c0:a4:f1, 78:31:c1:c6:3f:c2, 10.0.0.1, f8:ed:a5:c0:a4:f1, 10.0.0.2, 78:31:c1:c6:3f:c2

Binary file not shown.

View file

@ -0,0 +1,13 @@
# @TEST-EXEC: bro -r $TRACES/arp-who-has.pcap %INPUT
# @TEST-EXEC: btest-diff .stdout
event arp_request(mac_src: string, mac_dst: string, SPA: addr, SHA: string, TPA: addr, THA: string)
{
print mac_src, mac_dst, SPA, SHA, TPA, THA;
}
event arp_reply(mac_src: string, mac_dst: string, SPA: addr, SHA: string, TPA: addr, THA: string)
{
print mac_src, mac_dst, SPA, SHA, TPA, THA;
}