Adapting diff-all so that it expands globs in both current and

baseline directory.

This way, it now spots if a Baseline file isn't produced anymore.

Closes #677.

CHANGES

@@ -1,4 +1,9 @@
 
+2.0-beta-98 | 2011-12-07 08:12:08 -0800
+
+  * Adapting test-suite's diff-all so that it expands globs in both
+    current and baseline directory. Closes #677. (Robin Sommer)
+
 2.0-beta-97 | 2011-12-06 11:49:29 -0800
 
   * Omit loading local-<node>.bro scripts from base cluster framework.

VERSION

@@ -1 +1 @@
-2.0-beta-97
+2.0-beta-98

testing/external/scripts/diff-all

@@ -1,6 +1,10 @@
 #! /usr/bin/env bash
 #
-# Runs btest-diff on $@ and fails if any fails.
+# Runs btest-diff on $@ and fails if any fails. If $@ contains globs, we expand
+# them relative to *both* the current directory and the test's baseline
+# directory so that we spot missing files. Note that you will need to quote
+# the globals in the TEST-EXEC line as otherwise they will have been expanded relative
+# to the current directory already when this scripts runs.
 
 diag=$TEST_DIAGNOSTICS
 
@@ -14,7 +18,10 @@ fi
 
 rc=0;
 
-for i in $@; do
+files_cwd=`ls $@`
+files_baseline=`cd $TEST_BASELINE && ls $@`
+
+for i in `echo $files_cwd $files_baseline | sort | uniq`; do
     if [[ "$i" != "loaded_scripts.log" && "$i" != "prof.log" ]]; then
         if ! btest-diff $i; then
            echo "" >>$diag

testing/external/scripts/skel/test.skeleton

@@ -1,5 +1,5 @@
 # @TEST-EXEC: zcat $TRACES/trace.gz | bro -r - %INPUT
-# @TEST-EXEC: $SCRIPTS/diff-all *.log
+# @TEST-EXEC: $SCRIPTS/diff-all '*.log'
 
 @load testing-setup
 @load test-all-policy