Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-09 10:08:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Deprecate VectorVal::Insert() taking raw Val*, use IntrusivePtr

Browse source
This commit is contained in:
Jon Siwek 2020-05-21 15:44:06 -07:00
parent de1e3d7d6d
commit 40db09ccbf
4 changed files with 18 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/Val.cc
View file

@ -3092,12 +3092,11 @@ bool VectorVal::AssignRepeat(unsigned int index, unsigned int how_many,
return true;
}
bool VectorVal::Insert(unsigned int index, Val* element)
bool VectorVal::Insert(unsigned int index, IntrusivePtr<Val> element)
{
if ( element &&
! same_type(element->GetType().get(), GetType()->AsVectorType()->Yield().get(), false) )
{
Unref(element);
return false;
}
@ -3111,7 +3110,7 @@ bool VectorVal::Insert(unsigned int index, Val* element)
// Note: we do *not* Ref() the element, if any, at this point.
// AssignExpr::Eval() already does this; other callers must remember
// to do it similarly.
val.vector_val->insert(it, element);
val.vector_val->insert(it, element.release());
Modified();
return true;