Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-08 01:28:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Make nearly all bool operators explicit.

Browse source 
These are a bit dangerous because the casting can happen in quite
unexpected circumstances and lead to undesirable comparison results.
This commit is contained in:
Johanna Amann 2018-01-18 14:02:03 -08:00
parent 5ed5587b5c
commit 41285abea5
7 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/file_analysis/Manager.cc
View file

@ -448,7 +448,7 @@ bool Manager::IsDisabled(analyzer::Tag tag)
if ( ! disabled )
disabled = internal_const_val("Files::disable")->AsTableVal();
Val* index = new Val(tag, TYPE_COUNT);
Val* index = new Val(bool(tag), TYPE_COUNT);
Val* yield = disabled->Lookup(index);
Unref(index);

2
src/file_analysis/Tag.h
View file

@ -46,7 +46,7 @@ public:
* otherwise this may allow nonsense/undesired comparison operations.
*
*/
operator bool() const { return *this != Tag(); }
explicit operator bool() const { return *this != Tag(); }
/**
* Assignment operator.