Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-08 01:28:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Some review cleanup in Val.cc

Browse source
This commit is contained in:
Tim Wojtulewicz 2020-12-03 09:56:40 -07:00
parent e652aff277
commit 42f2691251
2 changed files with 27 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/Val.h
View file

@ -403,7 +403,7 @@ public:
: BoolVal(bro_int_t(b))
{}
bool Get() const { return int_val; }
bool Get() const { return static_cast<bool>(int_val); }
};
class CountVal : public UnsignedValImplementation {
@ -438,7 +438,7 @@ public:
quantity * units)
{}
double Get() const { return double_val; }
// Same as for IntVal: no Get() method needed.
protected:
void ValDescribe(ODesc* d) const override;
@ -449,7 +449,7 @@ public:
TimeVal(double t) : DoubleValImplementation(base_type(TYPE_TIME), t)
{}
double Get() const { return double_val; }
// Same as for IntVal: no Get() method needed.
};
class PortVal final : public UnsignedValImplementation {
@ -1328,8 +1328,6 @@ class EnumVal final : public IntValImplementation {
public:
ValPtr SizeVal() const override;
int Get() const { return int_val; }
protected:
friend class Val;
friend class EnumType;
@ -1472,6 +1470,15 @@ public:
bool Insert(unsigned int index, Val* element)
{ return Insert(index, {AdoptRef{}, element}); }
/**
* Inserts an element at the end of the vector.
* @param element The value to insert into the vector.
* @return True if the element was inserted or false if the element was
* the wrong type.
*/
bool Append(ValPtr element)
{ return Insert(Size(), element); }
// Removes an element at a specific position.
bool Remove(unsigned int index);