Remove opaque of ocsp_resp.

Only used in one event, without any way to use the opaque for anything
else. At this point this just seems like a complication that has no
reason to be there.
This commit is contained in:
Johanna Amann 2019-06-18 11:09:16 -07:00
parent c068daa258
commit 446b5cb90e
11 changed files with 14 additions and 85 deletions

View file

@ -5,7 +5,6 @@
#include <string>
#include "OpaqueVal.h"
#include "../File.h"
#include "Analyzer.h"
#include "X509Common.h"
@ -14,8 +13,6 @@
namespace file_analysis {
class OCSP_RESPVal;
class OCSP : public file_analysis::X509Common {
public:
bool DeliverStream(const u_char* data, uint64 len) override;
@ -29,7 +26,7 @@ protected:
OCSP(RecordVal* args, File* file, bool request);
private:
void ParseResponse(OCSP_RESPVal*);
void ParseResponse(OCSP_RESPONSE*);
void ParseRequest(OCSP_REQUEST*);
void ParseExtensionsSpecific(X509_EXTENSION* ex, bool, ASN1_OBJECT*, const char*) override;
@ -37,19 +34,6 @@ private:
bool request = false; // true if ocsp request, false if reply
};
class OCSP_RESPVal: public OpaqueVal {
public:
explicit OCSP_RESPVal(OCSP_RESPONSE *);
~OCSP_RESPVal() override;
OCSP_RESPONSE *GetResp() const;
protected:
OCSP_RESPVal();
DECLARE_OPAQUE_VALUE(OCSP_RESPVal)
private:
OCSP_RESPONSE *ocsp_resp;
};
}
#endif