Fix clang-tidy modernize-macro-to-enum warnings in headers

cmake_templates/zeek-config.h.in

@@ -1,4 +1,5 @@
 // See the file "COPYING" in the main distribution directory for copyright.
+// NOLINTBEGIN(modernize-macro-to-enum)
 
 #pragma once
 
@@ -306,3 +307,5 @@
 
 /* compiled with Spicy support */
 #cmakedefine HAVE_SPICY
+
+// NOLINTEND(modernize-macro-to-enum)

src/Val.h

@@ -18,12 +18,12 @@
 // We have four different port name spaces: TCP, UDP, ICMP, and UNKNOWN.
 // We distinguish between them based on the bits specified in the *_PORT_MASK
 // entries specified below.
-#define NUM_PORT_SPACES 4
-#define PORT_SPACE_MASK 0x30000
+constexpr int NUM_PORT_SPACES = 4;
+constexpr uint32_t PORT_SPACE_MASK = 0x30000;
 
-#define TCP_PORT_MASK 0x10000
-#define UDP_PORT_MASK 0x20000
-#define ICMP_PORT_MASK 0x30000
+constexpr uint32_t TCP_PORT_MASK = 0x10000;
+constexpr uint32_t UDP_PORT_MASK = 0x20000;
+constexpr uint32_t ICMP_PORT_MASK = 0x30000;
 
 namespace zeek {
 

src/analyzer/protocol/bittorrent/BitTorrentTracker.h

@@ -6,7 +6,7 @@
 
 #include "zeek/analyzer/protocol/tcp/TCP.h"
 
-#define BTTRACKER_BUF 2048
+constexpr uint32_t BTTRACKER_BUF = 2048;
 
 namespace zeek {
 

src/analyzer/protocol/bittorrent/bittorrent.pac

@@ -4,7 +4,7 @@
 %include zeek.pac
 
 %extern{
-#define MSGLEN_LIMIT 0x40000
+constexpr uint32_t MSGLEN_LIMIT = 0x40000;
 
 #include "zeek/analyzer/protocol/bittorrent/events.bif.h"
 %}