Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-10 18:48:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

resolved some TODO comments

Browse source
This commit is contained in:
Vern Paxson 2021-03-22 21:20:52 -07:00
parent 245108e86e
commit 46e303b000
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/Val.h
View file

@ -1288,8 +1288,10 @@ public:
return record_val->at(field).table_val->Get(); return record_val->at(field).table_val->Get();
else else
{ {
// TODO: error here, although because of the // It's an error to reach here, although because of
// type trait it really shouldn't ever get here. // the type trait we really shouldn't ever wind up
// here.
reporter->InternalError("bad type in GetFieldAs");
} }
} }
@ -1305,7 +1307,7 @@ public:
else if constexpr ( std::is_floating_point_v<T> ) else if constexpr ( std::is_floating_point_v<T> )
return record_val->at(field).double_val; return record_val->at(field).double_val;
// Could add other types here using type traits, // Note: we could add other types here using type traits,
// such as is_same_v<T, std::string>, etc. // such as is_same_v<T, std::string>, etc.
return T{}; return T{};