Merge remote-tracking branch 'MaxKellermann/eliminate_code

* MaxKellermann/eliminate_code:
  RE: make the RE_Matcher destructor non-virtual
  analyzer/protocol/smtp: remove unnecessary nullptr check
  analyzer/Manager: remove unnecessary clear() calls from destructor
  analyzer/protocol/http: remove unnecessary empty destructor
  iosource/pcap/Source: remove unused fields `last_hdr`, `last_data`
  iosource/Manager: eliminate two std::string copies
This commit is contained in:
Tim Wojtulewicz 2020-02-14 16:16:54 -07:00
commit 47d813badc
9 changed files with 21 additions and 19 deletions

View file

@ -325,8 +325,8 @@ static std::pair<std::string, std::string> split_prefix(std::string path)
PktSrc* Manager::OpenPktSrc(const std::string& path, bool is_live)
{
std::pair<std::string, std::string> t = split_prefix(path);
std::string prefix = t.first;
std::string npath = t.second;
const auto& prefix = t.first;
const auto& npath = t.second;
// Find the component providing packet sources of the requested prefix.