Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix GCC warnings about unintended pointer comparisions

Browse source 
When inspecting Spicy values for marshalling to Zeek we should receive
field identifiers as owned `std::string` so it should be safe to
directly compare them against `const char[]`. It seems that e.g.,
gcc-9.4.0's analysis sees things differently and warns of a comparision
of `const char*` (which as written would compare pointer values; the
correct API for this would be `::strlen`).

This patch addresses that warning by visiting with type which supports
`==` comparison, in particular, take a `std::string_view` so we could
even visit `const char*` identifiers.
This commit is contained in:
Benjamin Bannier 2023-09-27 17:12:24 +02:00
parent c6486e70ef
commit 517074bf41
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/spicy/runtime-support.h
View file

@ -11,6 +11,7 @@
#include <optional> #include <optional>
#include <ostream> #include <ostream>
#include <string> #include <string>
#include <string_view>
#include <tuple> #include <tuple>
#include <utility> #include <utility>
@ -882,7 +883,7 @@ inline ValPtr to_val(const T& t, TypePtr target) {
auto num_fields = rtype->NumFields(); auto num_fields = rtype->NumFields();
t.__visit([&](const auto& name, const auto& val) { t.__visit([&](std::string_view name, const auto& val) {
if ( idx >= num_fields ) if ( idx >= num_fields )
throw TypeMismatch(hilti::rt::fmt("no matching record field for field '%s'", name)); throw TypeMismatch(hilti::rt::fmt("no matching record field for field '%s'", name));