Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Use bool instead of int flag in FTP analyzer's parse_eftp method

Browse source
This commit is contained in:
Tim Wojtulewicz 2025-05-05 18:21:00 -07:00
parent c0b09665b9
commit 517dfff529
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/analyzer/protocol/ftp/functions.bif
View file

@ -49,7 +49,7 @@ static zeek::RecordValPtr parse_eftp(const char* line)
int net_proto = 0; // currently not used int net_proto = 0; // currently not used
zeek::IPAddr addr; // unspecified IPv6 address (all 128 bits zero) zeek::IPAddr addr; // unspecified IPv6 address (all 128 bits zero)
int port = 0; int port = 0;
int good = 0; bool good = false;
if ( line ) if ( line )
{ {
@ -61,12 +61,12 @@ static zeek::RecordValPtr parse_eftp(const char* line)
if ( *line ) if ( *line )
{ {
good = 1; good = true;
++line; // skip delimiter ++line; // skip delimiter
net_proto = strtol(line, &next_delim, 10); net_proto = strtol(line, &next_delim, 10);
if ( *next_delim != delimiter ) if ( *next_delim != delimiter )
good = 0; good = false;
line = next_delim; line = next_delim;
if ( *line ) if ( *line )
@ -78,7 +78,7 @@ static zeek::RecordValPtr parse_eftp(const char* line)
if ( nptr == NULL ) if ( nptr == NULL )
{ {
nptr = line + strlen(line); nptr = line + strlen(line);
good = 0; good = false;
} }
std::string s(line, nptr-line); // extract IP address std::string s(line, nptr-line); // extract IP address
@ -95,12 +95,12 @@ static zeek::RecordValPtr parse_eftp(const char* line)
++line; // now the port ++line; // now the port
port = strtol(line, &next_delim, 10); port = strtol(line, &next_delim, 10);
if ( *next_delim != delimiter ) if ( *next_delim != delimiter )
good = 0; good = false;
if ( port < 0 || port > 65535 ) if ( port < 0 || port > 65535 )
{ {
port = 0; port = 0;
good = 0; good = false;
} }
} }
} }