Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-17 05:58:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Make x509 end-of-string-check nicer.

Browse source 
Use remaining instead of the total length, in case someone changes the
code later and changes pString before.
This commit is contained in:
Johanna Amann 2015-09-18 12:55:55 -07:00
parent 708ede22c6
commit 5785530c6b
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/file_analysis/analyzer/x509/X509.cc
View file

@ -535,7 +535,7 @@ double file_analysis::X509::GetTimeFromAsn1(const ASN1_TIME* atime, const char*
return 0; return 0;
} }
if ( pString[atime->length-1] != 'Z' ) if ( pString[remaining-1] != 'Z' )
{ {
// not valid according to RFC 2459 4.1.2.5.1 // not valid according to RFC 2459 4.1.2.5.1
reporter->Weird(fmt("Could not parse UTC time in non-YY-format in X509 certificate (x509 %s)", fid)); reporter->Weird(fmt("Could not parse UTC time in non-YY-format in X509 certificate (x509 %s)", fid));