Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 06:38:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix clang-tidy modernize-pass-by-value findings

Browse source
This commit is contained in:
Tim Wojtulewicz 2025-05-15 09:25:39 -07:00
parent 46e67a749a
commit 5930d2f944
22 changed files with 37 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/file_analysis/Analyzer.cc
View file

@ -24,7 +24,7 @@ void Analyzer::SetAnalyzerTag(const zeek::Tag& arg_tag) {
}
Analyzer::Analyzer(zeek::Tag arg_tag, RecordValPtr arg_args, File* arg_file)
: tag(arg_tag),
: tag(std::move(arg_tag)),
args(std::move(arg_args)),
file(arg_file),
got_stream_delivery(false),

4
src/file_analysis/FileTimer.cc
View file

@ -7,8 +7,8 @@
namespace zeek::file_analysis::detail {
FileTimer::FileTimer(double t, const std::string& id, double interval)
: zeek::detail::Timer(t + interval, zeek::detail::TIMER_FILE_ANALYSIS_INACTIVITY), file_id(id) {
FileTimer::FileTimer(double t, std::string id, double interval)
: zeek::detail::Timer(t + interval, zeek::detail::TIMER_FILE_ANALYSIS_INACTIVITY), file_id(std::move(id)) {
DBG_LOG(DBG_FILE_ANALYSIS, "New %f second timeout timer for %s", interval, file_id.c_str());
}

2
src/file_analysis/FileTimer.h
View file

@ -19,7 +19,7 @@ public:
* @param id the file identifier which will be checked for inactivity.
* @param interval amount of time after \a t to check for inactivity.
*/
FileTimer(double t, const std::string& id, double interval);
FileTimer(double t, std::string id, double interval);
/**
* Check inactivity of file_analysis::File corresponding to #file_id,

4
src/file_analysis/analyzer/extract/Extract.cc
View file

@ -11,10 +11,10 @@
namespace zeek::file_analysis::detail {
Extract::Extract(RecordValPtr args, file_analysis::File* file, const std::string& arg_filename, uint64_t arg_limit,
Extract::Extract(RecordValPtr args, file_analysis::File* file, std::string arg_filename, uint64_t arg_limit,
bool arg_limit_includes_missing)
: file_analysis::Analyzer(file_mgr->GetComponentTag("EXTRACT"), std::move(args), file),
filename(arg_filename),
filename(std::move(arg_filename)),
limit(arg_limit),
written(0),
limit_includes_missing(arg_limit_includes_missing) {

2
src/file_analysis/analyzer/extract/Extract.h
View file

@ -64,7 +64,7 @@ protected:
* @param arg_limit the maximum allowed file size.
* @param arg_limit_includes_missing missing bytes count towards limit if true.
*/
Extract(RecordValPtr args, file_analysis::File* file, const std::string& arg_filename, uint64_t arg_limit,
Extract(RecordValPtr args, file_analysis::File* file, std::string arg_filename, uint64_t arg_limit,
bool arg_limit_includes_missing);
private: