mirror of
https://github.com/zeek/zeek.git
synced 2025-10-02 14:48:21 +00:00
Fix a number of Coverity findings
- 1458048: Use-after-free in the SQLite logger - 1457823: Missing a break statement in script-opt reduction - 1453966: Dead code in CompHash - 1445417: Unintialized variable in StaticHash64 - 1437716: Unintialized variables in FileInfo in scan.l
This commit is contained in:
parent
7dd18ec906
commit
5e00f78920
5 changed files with 8 additions and 6 deletions
|
@ -512,7 +512,7 @@ int CompositeHash::SingleTypeKeySize(Type* bt, const Val* v,
|
||||||
if ( ! v )
|
if ( ! v )
|
||||||
return (optional && ! calc_static_size) ? sz : 0;
|
return (optional && ! calc_static_size) ? sz : 0;
|
||||||
|
|
||||||
const RecordVal* rv = v ? v->AsRecordVal() : nullptr;
|
const RecordVal* rv = v->AsRecordVal();
|
||||||
RecordType* rt = bt->AsRecordType();
|
RecordType* rt = bt->AsRecordType();
|
||||||
int num_fields = rt->NumFields();
|
int num_fields = rt->NumFields();
|
||||||
|
|
||||||
|
|
|
@ -67,7 +67,7 @@ void KeyedHash::Hash256(const void* bytes, uint64_t size, hash256_t* result)
|
||||||
|
|
||||||
hash64_t KeyedHash::StaticHash64(const void* bytes, uint64_t size)
|
hash64_t KeyedHash::StaticHash64(const void* bytes, uint64_t size)
|
||||||
{
|
{
|
||||||
hash64_t result;
|
hash64_t result = 0;
|
||||||
highwayhash::InstructionSets::Run<highwayhash::HighwayHash>(cluster_highwayhash_key, reinterpret_cast<const char *>(bytes), size, &result);
|
highwayhash::InstructionSets::Run<highwayhash::HighwayHash>(cluster_highwayhash_key, reinterpret_cast<const char *>(bytes), size, &result);
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
|
@ -169,15 +169,16 @@ bool SQLite::DoInit(const WriterInfo& info, int arg_num_fields,
|
||||||
}
|
}
|
||||||
|
|
||||||
create += fieldname;
|
create += fieldname;
|
||||||
sqlite3_free(fieldname);
|
|
||||||
|
|
||||||
string type = GetTableType(field->type, field->subtype);
|
string type = GetTableType(field->type, field->subtype);
|
||||||
if ( type == "" )
|
if ( type == "" )
|
||||||
{
|
{
|
||||||
InternalError(Fmt("Could not determine type for field %u:%s", i, fieldname));
|
InternalError(Fmt("Could not determine type for field %u:%s", i, fieldname));
|
||||||
|
sqlite3_free(fieldname);
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
sqlite3_free(fieldname);
|
||||||
create += " " + type;
|
create += " " + type;
|
||||||
|
|
||||||
/* if ( !field->optional ) {
|
/* if ( !field->optional ) {
|
||||||
|
|
|
@ -106,9 +106,9 @@ public:
|
||||||
|
|
||||||
YY_BUFFER_STATE buffer_state;
|
YY_BUFFER_STATE buffer_state;
|
||||||
std::string restore_module;
|
std::string restore_module;
|
||||||
const char* name;
|
const char* name = nullptr;
|
||||||
int line;
|
int line = 0;
|
||||||
int level;
|
int level = 0;
|
||||||
};
|
};
|
||||||
|
|
||||||
// A stack of input buffers we're scanning. file_stack[len-1] is the
|
// A stack of input buffers we're scanning. file_stack[len-1] is the
|
||||||
|
|
|
@ -959,6 +959,7 @@ TraversalCode CSE_ValidityChecker::PreExpr(const Expr* e)
|
||||||
return TC_ABORTALL;
|
return TC_ABORTALL;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
break;
|
||||||
|
|
||||||
case EXPR_APPEND_TO:
|
case EXPR_APPEND_TO:
|
||||||
// This doesn't directly change any identifiers, but does
|
// This doesn't directly change any identifiers, but does
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue