Merge remote-tracking branch 'origin/topic/awelzel/smb1-avoid-dialect-index-error'

* origin/topic/awelzel/smb1-avoid-dialect-index-error:
  smb1: Ensure existence of dialect_index in offered dialects
This commit is contained in:
Tim Wojtulewicz 2022-11-16 14:51:35 -07:00
commit 6055a85b3c
3 changed files with 8 additions and 3 deletions

View file

@ -1,3 +1,7 @@
5.2.0-dev.322 | 2022-11-16 14:51:35 -0700
* smb1: Ensure existence of dialect_index in offered dialects (Arne Welzel, Corelight)
5.2.0-dev.320 | 2022-11-16 14:50:58 -0700 5.2.0-dev.320 | 2022-11-16 14:50:58 -0700
* ssh: Test for c$ssh$analyzer_id existence (Arne Welzel, Corelight) * ssh: Test for c$ssh$analyzer_id existence (Arne Welzel, Corelight)

View file

@ -1 +1 @@
5.2.0-dev.320 5.2.0-dev.322

View file

@ -89,9 +89,10 @@ event smb1_negotiate_response(c: connection, hdr: SMB1::Header, response: SMB1::
{ {
if ( c$smb_state$current_cmd?$smb1_offered_dialects ) if ( c$smb_state$current_cmd?$smb1_offered_dialects )
{ {
if ( response?$ntlm ) local offered_dialects = c$smb_state$current_cmd$smb1_offered_dialects;
if ( response?$ntlm && response$ntlm$dialect_index < |offered_dialects| )
{ {
c$smb_state$current_cmd$argument = c$smb_state$current_cmd$smb1_offered_dialects[response$ntlm$dialect_index]; c$smb_state$current_cmd$argument = offered_dialects[response$ntlm$dialect_index];
} }
delete c$smb_state$current_cmd$smb1_offered_dialects; delete c$smb_state$current_cmd$smb1_offered_dialects;