Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 06:38:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

GH-1080: Rename conflicting NetControl::DROP enum definitions

Browse source 
``NetControl::DROP`` had 3 conflicting definitions that could potentially
be used incorrectly without any warnings or type-checking errors.
Such enum redefinition conflicts are now caught and treated as errors,
so the ``NetControl::DROP`` enums had to be renamed:

* The use as enum of type ``Log::ID`` is renamed to ``NetControl::DROP_LOG``

* The use as enum of type ``NetControl::CatchReleaseInfo`` is renamed to
  ``NetControl::DROP_REQUESTED``

* The use as enum of type ``NetControl::RuleType`` is unchanged and still
  named ``NetControl::DROP``
This commit is contained in:
Jon Siwek 2020-07-31 16:09:58 -07:00
parent 8517d70e52
commit 613b27eec7
6 changed files with 55 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

29
NEWS
View file

@ -6,6 +6,35 @@ release. For an exhaustive list of changes, see the ``CHANGES`` file
Zeek 4.0.0
==========
New Functionality
-----------------
TODO: nothing notable yet
Changed Functionality
---------------------
- ``NetControl::DROP`` had 3 conflicting definitions that could potentially
be used incorrectly without any warnings or type-checking errors.
Such enum redefinition conflicts are now caught and treated as errors,
so the ``NetControl::DROP`` enums had to be renamed:
- The use as enum of type ``Log::ID`` is renamed to ``NetControl::DROP_LOG``
- The use as enum of type ``NetControl::CatchReleaseInfo`` is renamed to
``NetControl::DROP_REQUESTED``
- The use as enum of type ``NetControl::RuleType`` is unchanged and still
named ``NetControl::DROP``
Removed Functionality
---------------------
TODO: nothing notable yet
Deprecated Functionality
------------------------
TODO: nothing notable yet
Zeek 3.2.0