Merge branch 'expr_missing_ref' of https://github.com/MaxKellermann/zeek

Updated the Ref() to happen inline with Assign() call for clarity.

* 'expr_missing_ref' of https://github.com/MaxKellermann/zeek:
  Expr: add missing reference in AssignExpr::InitVal()
This commit is contained in:
Jon Siwek 2020-02-20 14:57:58 -08:00
commit 678115803b
3 changed files with 6 additions and 2 deletions

View file

@ -1,4 +1,8 @@
3.2.0-dev.71 | 2020-02-20 14:57:58 -0800
* Fix missing reference count incrment in AssignExpr::InitVal() (Max Kellermann)
3.2.0-dev.69 | 2020-02-19 18:40:58 -0800 3.2.0-dev.69 | 2020-02-19 18:40:58 -0800
* Fix various reference counting issues in Assign() implementations/callers (Jon Siwek, Corelight) * Fix various reference counting issues in Assign() implementations/callers (Jon Siwek, Corelight)

View file

@ -1 +1 @@
3.2.0-dev.69 3.2.0-dev.71

View file

@ -2459,7 +2459,7 @@ Val* AssignExpr::InitVal(const BroType* t, Val* aggr) const
if ( ! v ) if ( ! v )
return 0; return 0;
aggr_r->Assign(field, v); aggr_r->Assign(field, v->Ref());
return v; return v;
} }