Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-12 19:48:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Mark one-parameter constructors as explicit & use override where possible

Browse source 
This commit marks (hopefully) ever one-parameter constructor as explicit.

It also uses override in (hopefully) all circumstances where a virtual
method is overridden.

There are a very few other minor changes - most of them were necessary
to get everything to compile (like one additional constructor). In one
case I changed an implicit operation to an explicit string conversion -
I think the automatically chosen conversion was much more convoluted.

This took longer than I want to admit but not as long as I feared :)
This commit is contained in:
Johanna Amann 2018-03-16 22:14:22 -07:00
parent 1f2bf50b49
commit 6d612ced3d
173 changed files with 1052 additions and 1046 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/Sessions.h
View file

@ -56,7 +56,7 @@ public:
: Timer(t, TIMER_TIMERMGR_EXPIRE), mgr(arg_mgr)
{ }
virtual void Dispatch(double t, int is_expire);
void Dispatch(double t, int is_expire) override;
protected:
TimerMgr* mgr;
@ -260,9 +260,9 @@ public:
: Timer(t + BifConst::Tunnel::ip_tunnel_timeout,
TIMER_IP_TUNNEL_INACTIVITY), tunnel_idx(p) {}
~IPTunnelTimer() {}
~IPTunnelTimer() override {}
void Dispatch(double t, int is_expire);
void Dispatch(double t, int is_expire) override;
protected:
NetSessions::IPPair tunnel_idx;