Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-16 05:28:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Mark one-parameter constructors as explicit & use override where possible

Browse source 
This commit marks (hopefully) ever one-parameter constructor as explicit.

It also uses override in (hopefully) all circumstances where a virtual
method is overridden.

There are a very few other minor changes - most of them were necessary
to get everything to compile (like one additional constructor). In one
case I changed an implicit operation to an explicit string conversion -
I think the automatically chosen conversion was much more convoluted.

This took longer than I want to admit but not as long as I feared :)
This commit is contained in:
Johanna Amann 2018-03-16 22:14:22 -07:00
parent 1f2bf50b49
commit 6d612ced3d
173 changed files with 1052 additions and 1046 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/SmithWaterman.h
View file

@ -41,10 +41,10 @@ public:
typedef BSSAlignVec::iterator BSSAlignVecIt;
typedef BSSAlignVec::const_iterator BSSAlignVecCIt;
BroSubstring(const string& string)
explicit BroSubstring(const string& string)
: BroString(string), _num(), _new(false) { }
BroSubstring(const BroString& string)
explicit BroSubstring(const BroString& string)
: BroString(string), _num(), _new(false) { }
BroSubstring(const BroSubstring& bst);
@ -97,7 +97,7 @@ private:
//
class BroSubstringCmp {
public:
BroSubstringCmp(unsigned int index) { _index = index; }
explicit BroSubstringCmp(unsigned int index) { _index = index; }
bool operator()(const BroSubstring* bst1, const BroSubstring* bst2) const;
private:
@ -119,7 +119,7 @@ enum SWVariant {
// Parameters for Smith-Waterman are stored in this simple record.
//
struct SWParams {
SWParams(unsigned int min_toklen = 3, SWVariant sw_variant = SW_SINGLE)
explicit SWParams(unsigned int min_toklen = 3, SWVariant sw_variant = SW_SINGLE)
{
_min_toklen = min_toklen;
_sw_variant = sw_variant;