Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-12 11:38:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Mark one-parameter constructors as explicit & use override where possible

Browse source 
This commit marks (hopefully) ever one-parameter constructor as explicit.

It also uses override in (hopefully) all circumstances where a virtual
method is overridden.

There are a very few other minor changes - most of them were necessary
to get everything to compile (like one additional constructor). In one
case I changed an implicit operation to an explicit string conversion -
I think the automatically chosen conversion was much more convoluted.

This took longer than I want to admit but not as long as I feared :)
This commit is contained in:
Johanna Amann 2018-03-16 22:14:22 -07:00
parent 1f2bf50b49
commit 6d612ced3d
173 changed files with 1052 additions and 1046 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/Stats.h
View file

@ -63,14 +63,14 @@ protected:
class ProfileLogger : public SegmentStatsReporter {
public:
ProfileLogger(BroFile* file, double interval);
~ProfileLogger();
~ProfileLogger() override;
void Log();
BroFile* File() { return file; }
protected:
void SegmentProfile(const char* name, const Location* loc,
double dtime, int dmem);
double dtime, int dmem) override;
private:
BroFile* file;
@ -82,7 +82,7 @@ private:
class SampleLogger : public SegmentStatsReporter {
public:
SampleLogger();
~SampleLogger();
~SampleLogger() override;
// These are called to report that a given function or location
// has been seen during the sampling.
@ -91,7 +91,7 @@ public:
protected:
void SegmentProfile(const char* name, const Location* loc,
double dtime, int dmem);
double dtime, int dmem) override;
TableVal* load_samples;
};