Fix a number of Coverity findings

1466460: Uninitialized field in gtp-analyzer.pac
1462465: Null pointer dereference in CompositeHash::SingleValHash
1462463: Copy/paste error in TCPSessionAdapter::build_syn_packet_val
1462067: Uninitialized fields in Zinst
This commit is contained in:
Tim Wojtulewicz 2021-11-29 10:43:34 -07:00
parent d2a9fcda0c
commit 72604f866b
4 changed files with 14 additions and 7 deletions

View file

@ -501,6 +501,11 @@ bool CompositeHash::SingleValHash(HashKey& hk, const Val* v, Type* bt, bool type
return true;
}
// All of the rest of the code here depends on v not being null, since it needs
// to get values from it.
if ( ! v )
return false;
switch ( t )
{
case TYPE_INTERNAL_INT:
@ -695,7 +700,7 @@ bool CompositeHash::SingleValHash(HashKey& hk, const Val* v, Type* bt, bool type
}
break;
case TYPE_INTERNAL_ERROR:
default:
return false;
}