Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-09 01:58:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix a number of Coverity findings

Browse source 
1466460: Uninitialized field in gtp-analyzer.pac
1462465: Null pointer dereference in CompositeHash::SingleValHash
1462463: Copy/paste error in TCPSessionAdapter::build_syn_packet_val
1462067: Uninitialized fields in Zinst
This commit is contained in:
Tim Wojtulewicz 2021-11-29 10:43:34 -07:00
parent d2a9fcda0c
commit 72604f866b
4 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/packet_analysis/protocol/gtpv1/gtpv1-analyzer.pac
View file

@ -610,7 +610,9 @@ connection GTPv1_Conn(zeek_analyzer: ZeekPacketAnalyzer)
%}
%init{
valid_orig = valid_resp = false;
valid_orig = false;
valid_resp = false;
packet = nullptr;
%}
function valid(orig: bool): bool

2
src/packet_analysis/protocol/tcp/TCPSessionAdapter.cc
View file

@ -422,7 +422,7 @@ static zeek::RecordValPtr build_syn_packet_val(bool is_orig, const zeek::IP_Hdr*
if ( TSval )
v->Assign(8, *TSval);
if ( TSval )
if ( TSecr )
v->Assign(9, *TSecr);
return v;