Fix a number of Coverity findings

1466460: Uninitialized field in gtp-analyzer.pac
1462465: Null pointer dereference in CompositeHash::SingleValHash
1462463: Copy/paste error in TCPSessionAdapter::build_syn_packet_val
1462067: Uninitialized fields in Zinst
This commit is contained in:
Tim Wojtulewicz 2021-11-29 10:43:34 -07:00
parent d2a9fcda0c
commit 72604f866b
4 changed files with 14 additions and 7 deletions

View file

@ -64,9 +64,9 @@ public:
}
// Create a stub instruction that will be populated later.
ZInst() { }
ZInst() = default;
virtual ~ZInst() { }
virtual ~ZInst() = default;
// Methods for printing out the instruction for debugging/maintenance.
void Dump(bro_uint_t inst_num, const FrameReMap* mappings) const;
@ -93,8 +93,8 @@ public:
// Returns a string describing the constant.
std::string ConstDump() const;
ZOp op;
ZAMOpType op_type;
ZOp op = OP_NOP;
ZAMOpType op_type = OP_X;
// Usually indices into frame, though sometimes hold integer constants.
// When an instruction has both frame slots and integer constants,