Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-10 18:48:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Improve func arg type checking.

Browse source
This commit is contained in:
Zeke Medley 2019-07-18 12:20:52 -07:00
parent 0ca6b3e013
commit 8a451a24e3
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/Type.cc
View file

@ -592,14 +592,18 @@ int FuncType::CheckArgs(const type_list* args, bool is_init) const
args->length(), my_args->length())); args->length(), my_args->length()));
return 0; return 0;
} }
int had_error = 1;
for ( int i = 0; i < my_args->length(); ++i ) for ( int i = 0; i < my_args->length(); ++i )
if ( ! same_type((*args)[i], (*my_args)[i], is_init) ) if ( ! same_type((*args)[i], (*my_args)[i], is_init) )
{ {
Warn(fmt("Type mismatch in function arguments. Expected %s, got %s.", Warn(fmt("Type mismatch in function arguments. Expected %s, got %s.",
type_name((*args)[i]->Tag()), type_name((*my_args)[i]->Tag()))); type_name((*args)[i]->Tag()), type_name((*my_args)[i]->Tag())));
had_error = 0; // continue checking types, don't return.
} }
return 1; return had_error;
} }
void FuncType::Describe(ODesc* d) const void FuncType::Describe(ODesc* d) const