Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-04 07:38:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix clang-tidy modernize-redundant-void-arg findings

Browse source
This commit is contained in:
Tim Wojtulewicz 2025-05-15 09:33:56 -07:00
parent 5930d2f944
commit 8c3eee7a87
3 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.clang-tidy
View file

@ -6,6 +6,7 @@ Checks: [-*,
modernize-make-unique, modernize-make-unique,
modernize-min-max-use-initializer-list, modernize-min-max-use-initializer-list,
modernize-pass-by-value, modernize-pass-by-value,
modernize-redundant-void-arg,
# Enable a very limited number of the cppcoreguidelines checkers. # Enable a very limited number of the cppcoreguidelines checkers.
# See the notes for some of the rest of them below. # See the notes for some of the rest of them below.

2
src/RE.cc
View file

@ -19,7 +19,7 @@ zeek::detail::NFA_Machine* zeek::detail::nfa = nullptr;
bool zeek::detail::case_insensitive = false; bool zeek::detail::case_insensitive = false;
bool zeek::detail::re_single_line = false; bool zeek::detail::re_single_line = false;
extern int RE_parse(void); extern int RE_parse();
extern void RE_set_input(const char* str); extern void RE_set_input(const char* str);
extern void RE_done_with_scan(); extern void RE_done_with_scan();

10
src/analyzer/protocol/bittorrent/BitTorrentTracker.cc
View file

@ -195,7 +195,7 @@ void BitTorrentTracker_Analyzer::EndpointEOF(bool is_orig) {
analyzer::tcp::TCP_ApplicationAnalyzer::EndpointEOF(is_orig); analyzer::tcp::TCP_ApplicationAnalyzer::EndpointEOF(is_orig);
} }
void BitTorrentTracker_Analyzer::InitBencParser(void) { void BitTorrentTracker_Analyzer::InitBencParser() {
benc_stack.clear(); benc_stack.clear();
benc_count.clear(); benc_count.clear();
@ -304,7 +304,7 @@ bool BitTorrentTracker_Analyzer::ParseRequest(char* line) {
void BitTorrentTracker_Analyzer::RequestGet(char* uri) { req_val_uri = new StringVal(uri); } void BitTorrentTracker_Analyzer::RequestGet(char* uri) { req_val_uri = new StringVal(uri); }
void BitTorrentTracker_Analyzer::EmitRequest(void) { void BitTorrentTracker_Analyzer::EmitRequest() {
AnalyzerConfirmation(); AnalyzerConfirmation();
if ( bt_tracker_request ) if ( bt_tracker_request )
@ -443,7 +443,7 @@ void BitTorrentTracker_Analyzer::ResponseBenc(int name_len, char* name, detail::
res_val_benc->Assign(std::move(name_), std::move(benc_value)); res_val_benc->Assign(std::move(name_), std::move(benc_value));
} }
void BitTorrentTracker_Analyzer::ResponseBody(void) { void BitTorrentTracker_Analyzer::ResponseBody() {
switch ( ResponseParseBenc() ) { switch ( ResponseParseBenc() ) {
case 0: case 0:
EmitResponse(); EmitResponse();
@ -466,7 +466,7 @@ void BitTorrentTracker_Analyzer::ResponseBody(void) {
} \ } \
} }
int BitTorrentTracker_Analyzer::ResponseParseBenc(void) { int BitTorrentTracker_Analyzer::ResponseParseBenc() {
auto INC_COUNT = [this]() { auto INC_COUNT = [this]() {
unsigned int count = benc_count.back(); unsigned int count = benc_count.back();
benc_count.pop_back(); benc_count.pop_back();
@ -696,7 +696,7 @@ int BitTorrentTracker_Analyzer::ResponseParseBenc(void) {
return -2; // need more data return -2; // need more data
} }
void BitTorrentTracker_Analyzer::EmitResponse(void) { void BitTorrentTracker_Analyzer::EmitResponse() {
AnalyzerConfirmation(); AnalyzerConfirmation();
if ( bt_tracker_response ) if ( bt_tracker_response )