Replace empty destructor bodies with =default definitions

This commit is contained in:
Tim Wojtulewicz 2023-07-06 14:01:11 -07:00
parent 1991b87a07
commit 90d0bc64fa
66 changed files with 45 additions and 124 deletions

View file

@ -206,7 +206,7 @@ class DNS_Request
public:
DNS_Request(std::string host, int request_type, bool async = false);
DNS_Request(const IPAddr& addr, bool async = false);
~DNS_Request();
~DNS_Request() = default;
std::string Host() const { return host; }
const IPAddr& Addr() const { return addr; }
@ -241,8 +241,6 @@ DNS_Request::DNS_Request(const IPAddr& addr, bool async) : addr(addr), async(asy
request_type = T_PTR;
}
DNS_Request::~DNS_Request() { }
void DNS_Request::MakeRequest(ares_channel channel, DNS_Mgr* mgr)
{
// This needs to get deleted at the end of the callback method.

View file

@ -340,7 +340,7 @@ class DictTestDummy
{
public:
DictTestDummy(int v) : v(v) { }
~DictTestDummy() { }
~DictTestDummy() = default;
int v = 0;
};

View file

@ -27,8 +27,6 @@ Discarder::Discarder()
discarder_maxlen = static_cast<int>(id::find_val("discarder_maxlen")->AsCount());
}
Discarder::~Discarder() { }
bool Discarder::IsActive()
{
return check_ip || check_tcp || check_udp || check_icmp;

View file

@ -18,11 +18,11 @@ using FuncPtr = IntrusivePtr<Func>;
namespace detail
{
class Discarder
class Discarder final
{
public:
Discarder();
~Discarder();
~Discarder() = default;
bool IsActive();

View file

@ -169,8 +169,6 @@ EventGroupPtr EventRegistry::LookupGroup(EventGroupKind kind, std::string_view n
EventGroup::EventGroup(EventGroupKind kind, std::string_view name) : kind(kind), name(name) { }
EventGroup::~EventGroup() noexcept { }
// Run through all ScriptFunc instances associated with this group and
// update their bodies after a group's enable/disable state has changed.
// Once that has completed, also update the Func's has_enabled_bodies

View file

@ -37,7 +37,7 @@ using ScriptFuncPtr = zeek::IntrusivePtr<ScriptFunc>;
}
// The registry keeps track of all events that we provide or handle.
class EventRegistry
class EventRegistry final
{
public:
EventRegistry();
@ -135,11 +135,11 @@ private:
* bodies of the tracked ScriptFuncs and updates them to reflect the current
* group state.
*/
class EventGroup
class EventGroup final
{
public:
EventGroup(EventGroupKind kind, std::string_view name);
~EventGroup() noexcept;
~EventGroup() noexcept = default;
EventGroup(const EventGroup& g) = delete;
EventGroup& operator=(const EventGroup&) = delete;

View file

@ -101,8 +101,6 @@ ValTrace::ValTrace(const ValPtr& _v) : v(_v)
}
}
ValTrace::~ValTrace() { }
bool ValTrace::operator==(const ValTrace& vt) const
{
auto& vt_v = vt.GetVal();

View file

@ -47,7 +47,7 @@ class ValTrace
{
public:
ValTrace(const ValPtr& v);
~ValTrace();
~ValTrace() = default;
const ValPtr& GetVal() const { return v; }
const TypePtr& GetType() const { return t; }

View file

@ -4237,8 +4237,6 @@ TableCoerceExpr::TableCoerceExpr(ExprPtr arg_op, TableTypePtr tt, bool type_chec
ExprError("coercion of non-table/set to table/set");
}
TableCoerceExpr::~TableCoerceExpr() { }
ValPtr TableCoerceExpr::Fold(Val* v) const
{
TableVal* tv = v->AsTableVal();
@ -4264,8 +4262,6 @@ VectorCoerceExpr::VectorCoerceExpr(ExprPtr arg_op, VectorTypePtr v)
ExprError("coercion of non-vector to vector");
}
VectorCoerceExpr::~VectorCoerceExpr() { }
ValPtr VectorCoerceExpr::Fold(Val* v) const
{
VectorVal* vv = v->AsVectorVal();
@ -4281,8 +4277,6 @@ ScheduleTimer::ScheduleTimer(const EventHandlerPtr& arg_event, Args arg_args, do
{
}
ScheduleTimer::~ScheduleTimer() { }
void ScheduleTimer::Dispatch(double /* t */, bool /* is_expire */)
{
if ( event )

View file

@ -1330,7 +1330,7 @@ class TableCoerceExpr final : public UnaryExpr
{
public:
TableCoerceExpr(ExprPtr op, TableTypePtr r, bool type_check = true);
~TableCoerceExpr() override;
~TableCoerceExpr() override = default;
// Optimization-related:
ExprPtr Duplicate() override;
@ -1343,7 +1343,7 @@ class VectorCoerceExpr final : public UnaryExpr
{
public:
VectorCoerceExpr(ExprPtr op, VectorTypePtr v);
~VectorCoerceExpr() override;
~VectorCoerceExpr() override = default;
// Optimization-related:
ExprPtr Duplicate() override;
@ -1356,7 +1356,7 @@ class ScheduleTimer final : public Timer
{
public:
ScheduleTimer(const EventHandlerPtr& event, zeek::Args args, double t);
~ScheduleTimer() override;
~ScheduleTimer() override = default;
void Dispatch(double t, bool is_expire) override;

View file

@ -801,8 +801,6 @@ BuiltinFunc::BuiltinFunc(built_in_func arg_func, const char* arg_name, bool arg_
id->SetConst();
}
BuiltinFunc::~BuiltinFunc() { }
bool BuiltinFunc::IsPure() const
{
return is_pure;

View file

@ -336,7 +336,7 @@ class BuiltinFunc final : public Func
{
public:
BuiltinFunc(built_in_func func, const char* name, bool is_pure);
~BuiltinFunc() override;
~BuiltinFunc() override = default;
bool IsPure() const override;
ValPtr Invoke(zeek::Args* args, Frame* parent) const override;

View file

@ -50,8 +50,6 @@ OpaqueMgr* OpaqueMgr::mgr()
OpaqueVal::OpaqueVal(OpaqueTypePtr t) : Val(std::move(t)) { }
OpaqueVal::~OpaqueVal() { }
const std::string& OpaqueMgr::TypeID(const OpaqueVal* v) const
{
auto x = _types.find(v->OpaqueName());

View file

@ -118,7 +118,7 @@ class OpaqueVal : public Val
{
public:
explicit OpaqueVal(OpaqueTypePtr t);
~OpaqueVal() override;
~OpaqueVal() override = default;
/**
* Serializes the value into a Broker representation.

View file

@ -103,10 +103,6 @@ bool SerializationFormat::WriteData(const void* b, size_t count)
return true;
}
BinarySerializationFormat::BinarySerializationFormat() { }
BinarySerializationFormat::~BinarySerializationFormat() { }
bool BinarySerializationFormat::Read(int* v, const char* tag)
{
uint32_t tmp;

View file

@ -106,8 +106,8 @@ protected:
class BinarySerializationFormat final : public SerializationFormat
{
public:
BinarySerializationFormat();
~BinarySerializationFormat() override;
BinarySerializationFormat() = default;
~BinarySerializationFormat() override = default;
bool Read(int* v, const char* tag) override;
bool Read(uint16_t* v, const char* tag) override;

View file

@ -1563,8 +1563,6 @@ ListVal::ListVal(TypeTag t) : Val(make_intrusive<TypeList>(t == TYPE_ANY ? nullp
tag = t;
}
ListVal::~ListVal() { }
ValPtr ListVal::SizeVal() const
{
return val_mgr->Count(vals.size());

View file

@ -663,7 +663,7 @@ class ListVal final : public Val
public:
explicit ListVal(TypeTag t);
~ListVal() override;
~ListVal() override = default;
TypeTag BaseTag() const { return tag; }

View file

@ -21,8 +21,6 @@ ConnSize_Analyzer::ConnSize_Analyzer(Connection* c)
start_time = c->StartTime();
}
ConnSize_Analyzer::~ConnSize_Analyzer() { }
void ConnSize_Analyzer::Init()
{
Analyzer::Init();

View file

@ -12,7 +12,7 @@ class ConnSize_Analyzer : public analyzer::Analyzer
{
public:
explicit ConnSize_Analyzer(Connection* c);
~ConnSize_Analyzer() override;
~ConnSize_Analyzer() override = default;
void Init() override;
void Done() override;

View file

@ -403,8 +403,6 @@ DNP3_TCP_Analyzer::DNP3_TCP_Analyzer(Connection* c)
{
}
DNP3_TCP_Analyzer::~DNP3_TCP_Analyzer() { }
void DNP3_TCP_Analyzer::Done()
{
TCP_ApplicationAnalyzer::Done();
@ -444,8 +442,6 @@ void DNP3_TCP_Analyzer::EndpointEOF(bool is_orig)
DNP3_UDP_Analyzer::DNP3_UDP_Analyzer(Connection* c) : DNP3_Base(this), Analyzer("DNP3_UDP", c) { }
DNP3_UDP_Analyzer::~DNP3_UDP_Analyzer() { }
void DNP3_UDP_Analyzer::DeliverPacket(int len, const u_char* data, bool orig, uint64_t seq,
const IP_Hdr* ip, int caplen)
{

View file

@ -71,7 +71,7 @@ class DNP3_TCP_Analyzer : public detail::DNP3_Base, public analyzer::tcp::TCP_Ap
{
public:
explicit DNP3_TCP_Analyzer(Connection* conn);
~DNP3_TCP_Analyzer() override;
~DNP3_TCP_Analyzer() override = default;
void Done() override;
void DeliverStream(int len, const u_char* data, bool orig) override;
@ -85,7 +85,7 @@ class DNP3_UDP_Analyzer : public detail::DNP3_Base, public analyzer::Analyzer
{
public:
explicit DNP3_UDP_Analyzer(Connection* conn);
~DNP3_UDP_Analyzer() override;
~DNP3_UDP_Analyzer() override = default;
void DeliverPacket(int len, const u_char* data, bool orig, uint64_t seq, const IP_Hdr* ip,
int caplen) override;

View file

@ -30,8 +30,6 @@ Contents_Rsh_Analyzer::Contents_Rsh_Analyzer(Connection* conn, bool orig,
}
}
Contents_Rsh_Analyzer::~Contents_Rsh_Analyzer() { }
void Contents_Rsh_Analyzer::DoDeliver(int len, const u_char* data)
{
int endp_state;

View file

@ -28,7 +28,7 @@ class Contents_Rsh_Analyzer final : public analyzer::tcp::ContentLine_Analyzer
{
public:
Contents_Rsh_Analyzer(Connection* conn, bool orig, Rsh_Analyzer* analyzer);
~Contents_Rsh_Analyzer() override;
~Contents_Rsh_Analyzer() override = default;
rsh_state RshSaveState() const { return save_state; }

View file

@ -26,8 +26,6 @@ Contents_Rlogin_Analyzer::Contents_Rlogin_Analyzer(Connection* conn, bool orig,
state = save_state = RLOGIN_SERVER_ACK;
}
Contents_Rlogin_Analyzer::~Contents_Rlogin_Analyzer() { }
void Contents_Rlogin_Analyzer::DoDeliver(int len, const u_char* data)
{
int endp_state;

View file

@ -36,7 +36,7 @@ class Contents_Rlogin_Analyzer final : public analyzer::tcp::ContentLine_Analyze
{
public:
Contents_Rlogin_Analyzer(Connection* conn, bool orig, Rlogin_Analyzer* analyzer);
~Contents_Rlogin_Analyzer() override;
~Contents_Rlogin_Analyzer() override = default;
void SetPeer(Contents_Rlogin_Analyzer* arg_peer) { peer = arg_peer; }

View file

@ -169,8 +169,6 @@ Contents_NCP_Analyzer::Contents_NCP_Analyzer(Connection* conn, bool orig,
resync_set = false;
}
Contents_NCP_Analyzer::~Contents_NCP_Analyzer() { }
void Contents_NCP_Analyzer::DeliverStream(int len, const u_char* data, bool orig)
{
analyzer::tcp::TCP_SupportAnalyzer::DeliverStream(len, data, orig);

View file

@ -91,7 +91,7 @@ class Contents_NCP_Analyzer : public analyzer::tcp::TCP_SupportAnalyzer
{
public:
Contents_NCP_Analyzer(Connection* conn, bool orig, detail::NCP_Session* session);
~Contents_NCP_Analyzer() override;
~Contents_NCP_Analyzer() override = default;
protected:
void DeliverStream(int len, const u_char* data, bool orig) override;

View file

@ -52,8 +52,6 @@ POP3_Analyzer::POP3_Analyzer(Connection* conn)
AddSupportAnalyzer(cl_resp);
}
POP3_Analyzer::~POP3_Analyzer() { }
void POP3_Analyzer::Done()
{
analyzer::tcp::TCP_ApplicationAnalyzer::Done();

View file

@ -74,7 +74,7 @@ class POP3_Analyzer final : public analyzer::tcp::TCP_ApplicationAnalyzer
{
public:
explicit POP3_Analyzer(Connection* conn);
~POP3_Analyzer() override;
~POP3_Analyzer() override = default;
void Done() override;
void DeliverStream(int len, const u_char* data, bool orig) override;

View file

@ -297,8 +297,6 @@ Portmapper_Analyzer::Portmapper_Analyzer(Connection* conn)
orig_rpc = resp_rpc = nullptr;
}
Portmapper_Analyzer::~Portmapper_Analyzer() { }
void Portmapper_Analyzer::Init()
{
RPC_Analyzer::Init();

View file

@ -33,7 +33,7 @@ class Portmapper_Analyzer : public RPC_Analyzer
{
public:
explicit Portmapper_Analyzer(Connection* conn);
~Portmapper_Analyzer() override;
~Portmapper_Analyzer() override = default;
void Init() override;
static analyzer::Analyzer* Instantiate(Connection* conn)

View file

@ -423,8 +423,6 @@ void Contents_RPC::Init()
analyzer::tcp::TCP_SupportAnalyzer::Init();
}
Contents_RPC::~Contents_RPC() { }
void Contents_RPC::Undelivered(uint64_t seq, int len, bool orig)
{
analyzer::tcp::TCP_SupportAnalyzer::Undelivered(seq, len, orig);

View file

@ -212,7 +212,7 @@ class Contents_RPC final : public analyzer::tcp::TCP_SupportAnalyzer
{
public:
Contents_RPC(Connection* conn, bool orig, detail::RPC_Interpreter* interp);
~Contents_RPC() override;
~Contents_RPC() override = default;
protected:
enum state_t

View file

@ -246,8 +246,6 @@ Manager::Manager(bool arg_use_real_time)
writer_id_type = nullptr;
}
Manager::~Manager() { }
void Manager::InitPostScript()
{
DBG_LOG(DBG_BROKER, "Initializing");

View file

@ -96,7 +96,7 @@ public:
/**
* Destructor.
*/
~Manager() override;
~Manager() override = default;
/**
* Initialization of the manager. This is called late during Zeek's

View file

@ -23,8 +23,6 @@ void Component::Initialize()
file_mgr->RegisterComponent(this, "ANALYZER_");
}
Component::~Component() { }
void Component::DoDescribe(ODesc* d) const
{
if ( factory_func )

View file

@ -60,7 +60,7 @@ public:
/**
* Destructor.
*/
~Component() override;
~Component() override = default;
/**
* Initialization function. This function has to be called before any

View file

@ -21,8 +21,6 @@ void Component::Initialize()
input_mgr->RegisterComponent(this, "READER_");
}
Component::~Component() { }
void Component::DoDescribe(ODesc* d) const
{
d->Add("Input::READER_");

View file

@ -36,7 +36,7 @@ public:
/**
* Destructor.
*/
~Component() override;
~Component() override = default;
/**
* Initialization function. This function has to be called before any

View file

@ -130,7 +130,7 @@ public:
string file_id;
AnalysisStream();
~AnalysisStream() override;
~AnalysisStream() override = default;
};
Manager::TableStream::TableStream()
@ -177,8 +177,6 @@ Manager::TableStream::~TableStream()
Manager::AnalysisStream::AnalysisStream() : Manager::Stream::Stream(ANALYSIS_STREAM), file_id() { }
Manager::AnalysisStream::~AnalysisStream() { }
Manager::Manager() : plugin::ComponentManager<input::Component>("Input", "Reader")
{
end_of_data = event_registry->Register("Input::end_of_data");

View file

@ -54,8 +54,6 @@ Config::Config(ReaderFrontend* frontend) : ReaderBackend(frontend)
}
}
Config::~Config() { }
void Config::DoClose() { }
bool Config::DoInit(const ReaderInfo& info, int num_fields, const Field* const* fields)

View file

@ -23,7 +23,7 @@ class Config : public ReaderBackend
{
public:
explicit Config(ReaderFrontend* frontend);
~Config() override;
~Config() override = default;
// prohibit copying and moving
Config(const Config&) = delete;

View file

@ -7,8 +7,6 @@ namespace zeek::plugin::detail::Zeek_RawReader
Plugin plugin;
Plugin::Plugin() { }
zeek::plugin::Configuration Plugin::Configure()
{
AddComponent(new zeek::input::Component("Raw", zeek::input::reader::detail::Raw::Instantiate));

View file

@ -13,7 +13,7 @@ namespace zeek::plugin::detail::Zeek_RawReader
class Plugin : public plugin::Plugin
{
public:
Plugin();
Plugin() = default;
plugin::Configuration Configure() override;

View file

@ -17,8 +17,6 @@ Component::Component(plugin::component::Type type, const std::string& name)
{
}
Component::~Component() { }
PktSrcComponent::PktSrcComponent(const std::string& arg_name, const std::string& arg_prefix,
InputType arg_type, factory_callback arg_factory)
: Component(plugin::component::PKTSRC, arg_name)
@ -28,8 +26,6 @@ PktSrcComponent::PktSrcComponent(const std::string& arg_name, const std::string&
factory = arg_factory;
}
PktSrcComponent::~PktSrcComponent() { }
const std::vector<std::string>& PktSrcComponent::Prefixes() const
{
return prefixes;
@ -110,8 +106,6 @@ PktDumperComponent::PktDumperComponent(const std::string& name, const std::strin
factory = arg_factory;
}
PktDumperComponent::~PktDumperComponent() { }
PktDumperComponent::factory_callback PktDumperComponent::Factory() const
{
return factory;

View file

@ -33,7 +33,7 @@ public:
/**
* Destructor.
*/
~Component() override;
~Component() override = default;
protected:
/**
@ -84,7 +84,7 @@ public:
/**
* Destructor.
*/
~PktSrcComponent() override;
~PktSrcComponent() override = default;
/**
* Returns the prefix(es) passed to the constructor.
@ -145,7 +145,7 @@ public:
/**
* Destructor.
*/
~PktDumperComponent() override;
~PktDumperComponent() override = default;
/**
* Returns the prefix(es) passed to the constructor.

View file

@ -16,8 +16,6 @@ PktDumper::PktDumper()
errmsg = "";
}
PktDumper::~PktDumper() { }
void PktDumper::Init()
{
Open();

View file

@ -28,7 +28,7 @@ public:
/**
* Destructor.
*/
virtual ~PktDumper();
virtual ~PktDumper() = default;
/**
* Returns the path associated with the dumper.

View file

@ -20,8 +20,6 @@ PcapDumper::PcapDumper(const std::string& path, bool arg_append)
pd = nullptr;
}
PcapDumper::~PcapDumper() { }
void PcapDumper::Open()
{
int linktype = -1;

View file

@ -18,7 +18,7 @@ class PcapDumper : public PktDumper
{
public:
PcapDumper(const std::string& path, bool append);
~PcapDumper() override;
~PcapDumper() override = default;
static PktDumper* Instantiate(const std::string& path, bool append);

View file

@ -21,8 +21,6 @@ void Component::Initialize()
log_mgr->RegisterComponent(this, "WRITER_");
}
Component::~Component() { }
void Component::DoDescribe(ODesc* d) const
{
d->Add("Log::WRITER_");

View file

@ -36,7 +36,7 @@ public:
/**
* Destructor.
*/
~Component() override;
~Component() override = default;
/**
* Initialization function. This function has to be called before any

View file

@ -66,8 +66,6 @@ BifItem& BifItem::operator=(const BifItem& other)
return *this;
}
BifItem::~BifItem() { }
void HookArgument::Describe(ODesc* d) const
{
switch ( type )

View file

@ -190,7 +190,7 @@ private:
/**
* A class describing an item defined in \c *.bif file.
*/
class BifItem
class BifItem final
{
public:
/**
@ -228,7 +228,7 @@ public:
/**
* Destructor.
*/
~BifItem();
~BifItem() = default;
/**
* Returns the script-level ID as passed into the constructor.

View file

@ -115,8 +115,6 @@ CardinalityCounter::CardinalityCounter(uint64_t arg_size, uint64_t arg_V, double
p = log2(m);
}
CardinalityCounter::~CardinalityCounter() { }
uint8_t CardinalityCounter::Rank(uint64_t hash_modified) const
{
hash_modified = hash_modified >> p;

View file

@ -61,7 +61,7 @@ public:
/**
* Destructor.
*/
~CardinalityCounter();
~CardinalityCounter() = default;
/**
* Add a new element to the counter.

View file

@ -813,8 +813,7 @@ void begin_RE()
class LocalNameFinder : public zeek::detail::TraversalCallback {
public:
LocalNameFinder()
{}
LocalNameFinder() = default;
virtual zeek::detail::TraversalCode PreExpr(const zeek::detail::Expr* expr)
{

View file

@ -58,8 +58,6 @@ Manager::Manager()
pimpl.swap(ptr);
}
Manager::~Manager() { }
void Manager::InitPostScript() { }
void Manager::InitPostBrokerSetup(broker::endpoint& ep)

View file

@ -50,7 +50,7 @@ public:
Manager& operator=(const Manager&) = delete;
virtual ~Manager();
virtual ~Manager() = default;
/**
* Initialization of the manager. This is called late during Zeek's

View file

@ -20,8 +20,6 @@ Formatter::Formatter(threading::MsgThread* t)
thread = t;
}
Formatter::~Formatter() { }
std::string Formatter::Render(const threading::Value::addr_t& addr)
{
if ( addr.family == IPv4 )

View file

@ -33,7 +33,7 @@ public:
/**
* Destructor.
*/
virtual ~Formatter();
virtual ~Formatter() = default;
/**
* Convert a list of threading values into an implementation specific

View file

@ -53,8 +53,6 @@ Ascii::Ascii(MsgThread* t, const SeparatorInfo& info) : Formatter(t)
separators = info;
}
Ascii::~Ascii() { }
bool Ascii::Describe(ODesc* desc, int num_fields, const Field* const* fields, Value** vals) const
{
for ( int i = 0; i < num_fields; i++ )

View file

@ -47,7 +47,7 @@ public:
* separators.
*/
Ascii(MsgThread* t, const SeparatorInfo& info);
~Ascii() override;
~Ascii() override = default;
virtual bool Describe(ODesc* desc, Value* val, const std::string& name = "") const override;
virtual bool Describe(ODesc* desc, int num_fields, const Field* const* fields,

View file

@ -37,8 +37,6 @@ JSON::JSON(MsgThread* t, TimeFormat tf, bool arg_include_unset_fields)
{
}
JSON::~JSON() { }
bool JSON::Describe(ODesc* desc, int num_fields, const Field* const* fields, Value** vals) const
{
rapidjson::StringBuffer buffer;

View file

@ -36,7 +36,7 @@ public:
};
JSON(MsgThread* t, TimeFormat tf, bool include_unset_fields = false);
~JSON() override;
~JSON() override = default;
bool Describe(ODesc* desc, Value* val, const std::string& name = "") const override;
bool Describe(ODesc* desc, int num_fields, const Field* const* fields,