Removing error check if an ASCII writer has been properly finished.

Turns out that in error situations, the final finish message might not
reach the writer anymore, as communication between the threads will be
shut down. Instead of aborting, we now just clean up in that case and
proceed. This isn't changing any other behaviour. The original error
check was in place mostly for helping debug the data flow between the
threads anyways.

Addresses BIT-1331.
This commit is contained in:
Robin Sommer 2015-04-15 09:51:15 -07:00
parent bafd354711
commit 9260638948
3 changed files with 10 additions and 5 deletions

View file

@ -181,10 +181,9 @@ bool Ascii::InitFormatter()
Ascii::~Ascii()
{
if ( ! ascii_done )
{
fprintf(stderr, "internal error: finish missing\n");
abort();
}
// In case of errors aborting the logging altogether,
// DoFinish() may not have been called.
CloseFile(network_time);
delete formatter;
}