Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

HashKey: Do not call Describe() unconditionally in DEBUG mode

Browse source 
An unnecessary overhead of the Hash() method was uncovered for DEBUG builds
due to computing a description of every HashKey() even when the DBG_HASHKEY
stream is not enabled. Squelch it.
This commit is contained in:
Arne Welzel 2023-02-14 10:36:27 +01:00
parent 252cd33283
commit 92e73606ba
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/Hash.cc
View file

@ -213,9 +213,12 @@ hash_t HashKey::Hash() const
if ( hash == 0 ) if ( hash == 0 )
hash = HashBytes(key, size); hash = HashBytes(key, size);
#ifdef DEBUG #ifdef DEBUG
if ( zeek::detail::debug_logger.IsEnabled(DBG_HASHKEY) )
{
ODesc d; ODesc d;
Describe(&d); Describe(&d);
DBG_LOG(DBG_HASHKEY, "HashKey %p %s", this, d.Description()); DBG_LOG(DBG_HASHKEY, "HashKey %p %s", this, d.Description());
}
#endif #endif
return hash; return hash;
} }