Merge branch 'topic/timw/switch-broker-error-to-error'

* topic/timw/switch-broker-error-to-error:
  Downgrade broker clone FatalError to an Error

(cherry picked from commit 2c17c85f55)
This commit is contained in:
Tim Wojtulewicz 2025-05-08 13:46:54 -07:00
parent 1807710a8c
commit 9369a6e3dd
3 changed files with 11 additions and 3 deletions

View file

@ -1,3 +1,9 @@
7.2.0-rc1.16 | 2025-05-08 13:47:36 -0700
* Downgrade broker clone FatalError to an Error (Tim Wojtulewicz, Corelight)
(cherry picked from commit 2c17c85f557245b6163ced014fc1d8089e1fcdf2)
7.2.0-rc1.14 | 2025-05-07 14:11:04 -0700
* Fix Broker metrics naming bugs that snuck in w/ last-minute renaming [skip ci] (Christian Kreibich, Corelight)

View file

@ -1 +1 @@
7.2.0-rc1.14
7.2.0-rc1.16

View file

@ -2086,8 +2086,10 @@ detail::StoreHandleVal* Manager::MakeClone(const string& name, double resync_int
auto handle = new detail::StoreHandleVal{*result};
Ref(handle);
if ( ! handle->proxy.valid() )
reporter->FatalError("Failed to create clone for data store %s", name.c_str());
if ( ! handle->proxy.valid() ) {
reporter->Error("Failed to create clone for data store %s", name.c_str());
return nullptr;
}
data_stores.emplace(name, handle);
if ( ! iosource_mgr->RegisterFd(handle->proxy.mailbox().descriptor(), this) )