mirror of
https://github.com/zeek/zeek.git
synced 2025-10-17 05:58:20 +00:00
Overhauling the internal reporting of messages to the user.
The Logger class is now in charge of reporting all errors, warnings, informational messages, weirds, and syslogs. All other components route their messages through the global bro_logger singleton. The Logger class comes with these reporting methods: void Message(const char* fmt, ...); void Warning(const char* fmt, ...); void Error(const char* fmt, ...); void FatalError(const char* fmt, ...); // Terminate Bro. void Weird(const char* name); [ .. some more Weird() variants ... ] void Syslog(const char* fmt, ...); void InternalWarning(const char* fmt, ...); void InternalError(const char* fmt, ...); // Terminates Bro. See Logger.h for more information on these. Generally, the reporting now works as follows: - All non-fatal message are reported in one of two ways: (1) At startup (i.e., before we start processing packets), they are logged to stderr. (2) During processing, they turn into events: event log_message%(msg: string, location: string%); event log_warning%(msg: string, location: string%); event log_error%(msg: string, location: string%); The script level can then handle them as desired. If we don't have an event handler, we fall back to reporting on stderr. - All fatal errors are logged to stderr and Bro terminates immediately. - Syslog(msg) directly syslogs, but doesn't do anything else. The three main types of messages can also be generated on the scripting layer via new Log::* bifs: Log::error(msg: string); Log::warning(msg: string); Log::message(msg: string); These pass through the bro_logger as well and thus are handled in the same way. Their output includes location information. More changes: - Removed the alarm statement and the alarm_hook event. - Adapted lots of locations to use the bro_logger, including some of the messages that were previously either just written to stdout, or even funneled through the alarm mechanism. - No distinction anymore between Error() and RunTime(). There's now only one class of errors; the line was quite blurred already anyway. - util.h: all the error()/warn()/message()/run_time()/pinpoint() functions are gone. Use the bro_logger instead now. - Script errors are formatted a bit differently due to the changes. What I've seen so far looks ok to me, but let me know if there's something odd. Notes: - The default handlers for the new log_* events are just dummy implementations for now since we need to integrate all this into the new scripts anyway. - I'm not too happy with the names of the Logger class and its instance bro_logger. We now have a LogMgr as well, which makes this all a bit confusing. But I didn't have a good idea for better names so I stuck with them for now. Perhaps we should merge Logger and LogMgr?
This commit is contained in:
parent
ff7b92ffc8
commit
93894eed9b
140 changed files with 2453 additions and 1054 deletions
22
src/Expr.cc
22
src/Expr.cc
|
@ -300,7 +300,7 @@ Val* NameExpr::Eval(Frame* f) const
|
|||
return v->Ref();
|
||||
else
|
||||
{
|
||||
RunTime("value used but not set");
|
||||
Error("value used but not set");
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
@ -383,7 +383,7 @@ bool NameExpr::DoUnserialize(UnserialInfo* info)
|
|||
if ( id )
|
||||
::Ref(id);
|
||||
else
|
||||
run_time("unserialized unknown global name");
|
||||
bro_logger->Warning("unserialized unknown global name");
|
||||
|
||||
delete [] name;
|
||||
}
|
||||
|
@ -626,7 +626,7 @@ Val* BinaryExpr::Eval(Frame* f) const
|
|||
|
||||
if ( v_op1->Size() != v_op2->Size() )
|
||||
{
|
||||
RunTime("vector operands are of different sizes");
|
||||
Error("vector operands are of different sizes");
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@ -1040,7 +1040,7 @@ Val* IncrExpr::DoSingleEval(Frame* f, Val* v) const
|
|||
|
||||
if ( k < 0 &&
|
||||
v->Type()->InternalType() == TYPE_INTERNAL_UNSIGNED )
|
||||
RunTime("count underflow");
|
||||
Error("count underflow");
|
||||
}
|
||||
|
||||
BroType* ret_type = Type();
|
||||
|
@ -1959,7 +1959,7 @@ Val* BoolExpr::Eval(Frame* f) const
|
|||
|
||||
if ( vec_v1->Size() != vec_v2->Size() )
|
||||
{
|
||||
RunTime("vector operands have different sizes");
|
||||
Error("vector operands have different sizes");
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@ -2341,7 +2341,7 @@ Val* CondExpr::Eval(Frame* f) const
|
|||
|
||||
if ( cond->Size() != a->Size() || a->Size() != b->Size() )
|
||||
{
|
||||
RunTime("vectors in conditional expression have different sizes");
|
||||
Error("vectors in conditional expression have different sizes");
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@ -2942,7 +2942,7 @@ Val* IndexExpr::Eval(Frame* f) const
|
|||
{
|
||||
if ( v_v1->Size() != v_v2->Size() )
|
||||
{
|
||||
RunTime("size mismatch, boolean index and vector");
|
||||
Error("size mismatch, boolean index and vector");
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@ -2989,7 +2989,7 @@ Val* IndexExpr::Fold(Val* v1, Val* v2) const
|
|||
if ( v )
|
||||
return v->Ref();
|
||||
|
||||
RunTime("no such index");
|
||||
Error("no such index");
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@ -4894,7 +4894,7 @@ Val* ListExpr::Eval(Frame* f) const
|
|||
Val* ev = exprs[i]->Eval(f);
|
||||
if ( ! ev )
|
||||
{
|
||||
RunTime("uninitialized list value");
|
||||
Error("uninitialized list value");
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@ -5623,7 +5623,7 @@ int same_expr(const Expr* e1, const Expr* e2)
|
|||
}
|
||||
|
||||
default:
|
||||
internal_error("bad tag in same_expr()");
|
||||
bro_logger->InternalError("bad tag in same_expr()");
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
@ -5643,7 +5643,7 @@ static Expr* make_constant(BroType* t, double d)
|
|||
case TYPE_INTERNAL_DOUBLE: v = new Val(double(d), t->Tag()); break;
|
||||
|
||||
default:
|
||||
internal_error("bad type in make_constant()");
|
||||
bro_logger->InternalError("bad type in make_constant()");
|
||||
}
|
||||
|
||||
return new ConstExpr(v);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue