Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-08 09:38:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Input/Logging: Make operator explicit

Browse source 
This fixes a long-standing todo for once we switch to C++11.
This commit is contained in:
Johanna Amann 2016-06-27 12:09:31 -07:00
parent 27a7edc0c5
commit 94e242f2fd
2 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/input/Tag.h
View file

@ -42,11 +42,8 @@ public:
/** /**
* Returns false if the tag represents an error value rather than a * Returns false if the tag represents an error value rather than a
* legal reader type. * legal reader type.
* TODO: make this conversion operator "explicit" (C++11) or use a
* "safe bool" idiom (not necessary if "explicit" is available),
* otherwise this may allow nonsense/undesired comparison operations.
*/ */
operator bool() const { return *this != Tag(); } explicit operator bool() const { return *this != Tag(); }
/** /**
* Assignment operator. * Assignment operator.

5
src/logging/Tag.h
View file

@ -42,11 +42,8 @@ public:
/** /**
* Returns false if the tag represents an error value rather than a * Returns false if the tag represents an error value rather than a
* legal writer type. * legal writer type.
* TODO: make this conversion operator "explicit" (C++11) or use a
* "safe bool" idiom (not necessary if "explicit" is available),
* otherwise this may allow nonsense/undesired comparison operations.
*/ */
operator bool() const { return *this != Tag(); } explicit operator bool() const { return *this != Tag(); }
/** /**
* Assignment operator. * Assignment operator.