Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 06:38:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

GH-174: Add warning for duplicate attributes

Browse source
This commit is contained in:
Tim Wojtulewicz 2020-08-24 08:24:12 -07:00
parent 9f802b2a4d
commit 989531826f
4 changed files with 20 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/Attr.cc
View file

@ -195,6 +195,12 @@ Attributes::Attributes(std::vector<AttrPtr> a,
void Attributes::AddAttr(AttrPtr attr)
{
// Display a warning for duplicated tags on a type. &log tags are intentionally
// ignored here because duplicate log tags on record types are valid, and don't
// cause any significant breakage for other types.
if ( attr->Tag() != ATTR_LOG && Find(attr->Tag()) )
reporter->Warning("Found duplicate tag %s", attr_name(attr->Tag()));
// We overwrite old attributes by deleting them first.
RemoveAttr(attr->Tag());
attrs_list.push_back(attr.get());