Integrate review feedback

* Add deprecation for MIME_Entity::ContentType(), use GetContentType()

* Add deprecation for MIME_Entity::ContentSubType(), use GetContentSubType()

* Add deprecation for MIME_Message::BuildHeaderVal(), use ToHeaderVal()

* Add deprecation for MIME_Message::BuildHeaderTable(), use ToHeaderTable()

* Add deprecation for mime::new_string_val(), use mime::to_stringval()

* Add deprecation for ARP_Analyzer::ConstructAddrVal(), use ToAddrVal()

* Add deprecation for ARP_Analyzer::EthAddrToStr(), use ToEthAddrStr()

* Change the Func::Call() replacement to be named Func::Invoke()
This commit is contained in:
Jon Siwek 2020-05-29 19:04:00 -07:00
parent 82ce64ca70
commit 9c133b9b10
22 changed files with 137 additions and 95 deletions

View file

@ -480,11 +480,11 @@ bool Manager::CreateTableStream(RecordVal* fval)
auto dst = fval->GetFieldOrDefault("destination");
// check if index fields match table description
int num = idx->NumFields();
size_t num = idx->NumFields();
const auto& tl = dst->GetType()->AsTableType()->IndexTypes();
int j;
size_t j;
for ( j = 0; j < static_cast<int>(tl.size()); ++j )
for ( j = 0; j < tl.size(); ++j )
{
if ( j >= num )
{
@ -1768,7 +1768,7 @@ bool Manager::CallPred(Func* pred_func, const int numvals, ...) const
va_end(lP);
auto v = pred_func->operator()(&vl);
auto v = pred_func->Invoke(&vl);
if ( v )
result = v->AsBool();