Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

GH-1713: Avoid unneeded reallocs in SerializationFormat::WriteData

Browse source
This commit is contained in:
Tim Wojtulewicz 2021-08-11 15:40:09 -07:00
parent 2476e36634
commit 9c29c8ddfc
1 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/SerializationFormat.cc
View file

@ -82,9 +82,17 @@ bool SerializationFormat::ReadData(void* b, size_t count)
bool SerializationFormat::WriteData(const void* b, size_t count) bool SerializationFormat::WriteData(const void* b, size_t count)
{ {
// Increase buffer if necessary. // Increase buffer if necessary.
bool size_changed = false;
while ( output_pos + count > output_size ) while ( output_pos + count > output_size )
{
output_size *= GROWTH_FACTOR; output_size *= GROWTH_FACTOR;
size_changed = true;
}
// The glibc standard states explicitly that calling realloc with the same
// size is a no-op, but the same claim can't be made on other platforms.
// There's really no reason to do that though.
if ( size_changed )
output = (char*)util::safe_realloc(output, output_size); output = (char*)util::safe_realloc(output, output_size);
memcpy(output + output_pos, b, count); memcpy(output + output_pos, b, count);