Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-04 15:48:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fixing a big pile of Coverity issues

Browse source 
1469562/1469558: Uninitialized fields in Func constructor
1469571/1469566: Null pointer dereference in Trigger::Init()
1469568: Uninitialized fields in CounterVector constructor
1469570: Uncaught exception in plugin manager
1469569: Resource leak in script_opt::Stmt
1469561/1469561: Uninitialized fields in ZBody constructor
1469559: Uninitialized fields in logging::Manager
1469563: Resource leak in ZAMCompiler::CompileDel
1469549/1469553/1469556: Context not fully initialized in HashVals
1469548: Remove dead code from IPAddr
1469551/1469554: Handle iosource_mgr registration failure in broker::Manager
1469552/1469572: Resource leaks in input::Manager
This commit is contained in:
Tim Wojtulewicz 2022-02-09 10:44:10 -07:00
parent 41abf8f422
commit a117c81d85
13 changed files with 93 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

58
src/logging/Manager.cc
View file

@ -31,27 +31,27 @@ namespace zeek::logging
struct Manager::Filter
{
Val* fval;
Val* fval = nullptr;
string name;
EnumVal* id;
Func* policy;
Func* path_func;
EnumVal* id = nullptr;
Func* policy = nullptr;
Func* path_func = nullptr;
string path;
Val* path_val;
EnumVal* writer;
TableVal* config;
TableVal* field_name_map;
Val* path_val = nullptr;
EnumVal* writer = nullptr;
TableVal* config = nullptr;
TableVal* field_name_map = nullptr;
string scope_sep;
string ext_prefix;
Func* ext_func;
int num_ext_fields;
bool local;
bool remote;
double interval;
Func* postprocessor;
Func* ext_func = nullptr;
int num_ext_fields = 0;
bool local = false;
bool remote = false;
double interval = 0.0;
Func* postprocessor = nullptr;
int num_fields;
threading::Field** fields;
int num_fields = 0;
threading::Field** fields = nullptr;
// Vector indexed by field number. Each element is a list of record
// indices defining a path leading to the value across potential
@ -63,26 +63,26 @@ struct Manager::Filter
struct Manager::WriterInfo
{
EnumVal* type;
double open_time;
detail::Timer* rotation_timer;
double interval;
Func* postprocessor;
WriterFrontend* writer;
WriterBackend::WriterInfo* info;
bool from_remote;
bool hook_initialized;
EnumVal* type = nullptr;
double open_time = 0.0;
detail::Timer* rotation_timer = nullptr;
double interval = 0.0;
Func* postprocessor = nullptr;
WriterFrontend* writer = nullptr;
WriterBackend::WriterInfo* info = nullptr;
bool from_remote = false;
bool hook_initialized = false;
string instantiating_filter;
};
struct Manager::Stream
{
EnumVal* id;
bool enabled;
EnumVal* id = nullptr;
bool enabled = false;
string name;
RecordType* columns;
RecordType* columns = nullptr;
EventHandlerPtr event;
Func* policy;
Func* policy = nullptr;
list<Filter*> filters;
using WriterPathPair = pair<int, string>;