fix warning.

Update baseline of stderr test to what it should be. There still is
a message ordering issue there (which is the last issue in the new
Raw reader I know of).

One message that sidesteps a bit of the usual processing does
not always arrive at the correct time (meaning it pops up from the
event queue too early). Even though it sidesteps a bit of the usual
processing that should not happen in my opinion (which clearly
does not matter). And I have not yet fully grasped how this can happen.

src/input/readers/Raw.cc

@@ -359,9 +359,7 @@ int64_t Raw::GetLine(FILE* arg_file)
 
 		}
 
-	if ( errno == 0 ) {
-		assert(false);
-	} else if ( errno == EAGAIN || errno == EWOULDBLOCK || errno == EINTR ) {
+	if ( errno == EAGAIN || errno == EWOULDBLOCK || errno == EINTR ) {
 		return -2;
 	} else {
 		// an error code we did no expect. This probably is bad.
@@ -369,6 +367,9 @@ int64_t Raw::GetLine(FILE* arg_file)
 		return -3;
 	}
 
+	InternalError("Internal control flow execution");
+	assert(false);
+
 	}
 
 // write to the stdin of the child process
@@ -546,7 +547,6 @@ bool Raw::DoUpdate()
 			EndCurrentSend();
 
 		SendEvent("InputRaw::process_finished", 4, vals);
-		
 	}
 
 

testing/btest/Baseline/scripts.base.frameworks.input.raw.stderr/out

@@ -1,6 +1,3 @@
-Process finished event
-input
-Exit code != 0
 Input::EVENT_NEW
 ..:
 F
@@ -25,3 +22,6 @@ T
 done
 End of Data event
 input
+Process finished event
+input
+Exit code != 0