Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 06:38:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

sumstats: Remove copy() for Broker::publish() calls

Browse source 
Serialization happens immediately at Broker::publish() time, there
should be no caching issues.
This commit is contained in:
Arne Welzel 2024-11-14 12:08:35 +01:00
parent 831614f907
commit aabc4a4114
1 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
scripts/base/frameworks/sumstats/cluster.zeek
View file

@ -151,12 +151,8 @@ event SumStats::cluster_get_result(uid: string, ss_name: string, key: Key, clean
{ {
if ( uid in sending_results && key in sending_results[uid] ) if ( uid in sending_results && key in sending_results[uid] )
{ {
# XXX: Is that comment stale?
#
# Note: copy is needed to compensate serialization caching issue. This should be
# changed to something else later.
Broker::publish(Cluster::manager_topic, SumStats::cluster_send_result, Broker::publish(Cluster::manager_topic, SumStats::cluster_send_result,
uid, ss_name, key, copy(sending_results[uid][key]), cleanup); uid, ss_name, key, sending_results[uid][key], cleanup);
delete sending_results[uid][key]; delete sending_results[uid][key];
} }
else else
@ -171,10 +167,8 @@ event SumStats::cluster_get_result(uid: string, ss_name: string, key: Key, clean
{ {
if ( ss_name in result_store && key in result_store[ss_name] ) if ( ss_name in result_store && key in result_store[ss_name] )
{ {
# Note: copy is needed to compensate serialization caching issue. This should be
# changed to something else later.
Broker::publish(Cluster::manager_topic, SumStats::cluster_send_result, Broker::publish(Cluster::manager_topic, SumStats::cluster_send_result,
uid, ss_name, key, copy(result_store[ss_name][key]), cleanup); uid, ss_name, key, result_store[ss_name][key], cleanup);
} }
else else
{ {