Patch for the Revoked bit set in DNSKEY Flag

A patch to parse the Revoked KSK flag combination in DNSKEY RR.
This commit is contained in:
Fatema BW 2019-01-15 17:38:43 -05:00 committed by GitHub
parent 39b1d49fc3
commit ac0ded1e0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -924,8 +924,10 @@ int DNS_Interpreter::ParseRR_DNSKEY(DNS_MsgInfo* msg,
//Evaluating the size of remaining bytes for Public Key
BroString* key = ExtractStream(data, len, rdlength - 4);
if ( dflags != 256 and dflags != 257 and dflags != 0 )
if ( dflags != 256 and dflags != 257 and dflags != 0 and dflags != 385 )
analyzer->Weird("DNSSEC_DNSKEY_Invalid_Flag", fmt("%d", dflags));
if ( dflags == 385 )
analyzer->Weird("DNSSEC_DNSKEY_Revoked_KSK", fmt("%d", dflags));
if ( dprotocol != 3 )
analyzer->Weird("DNSSEC_DNSKEY_Invalid_Protocol", fmt("%d", dprotocol));