TapAnalyzer: More verdict to action rename

Relates to #4725 #4337
This commit is contained in:
Arne Welzel 2025-08-05 19:56:07 +02:00
parent 1e05588e8e
commit b4925fbd16
3 changed files with 44 additions and 44 deletions

View file

@ -25,7 +25,7 @@ enum class PacketAction : uint8_t {
* Reason why delivery of a packet would be skipped.
*/
enum class SkipReason : uint8_t {
None, ///< None is used when the verdict is Deliver.
None, ///< None is used when the action is Deliver.
Unknown, ///< Placeholder if no other value fits.
BadChecksum, ///< The packet's checksum is invalid and ignore_checksums is false.
BadProtoHeader, ///< Something was off with the lengths or offsets in the protocol header.
@ -53,7 +53,7 @@ public:
*
* @param pkt The packet being processed.
* @param action Either Deliver or Skip as determined by session analyzers.
* @param skip_reason If verdict is Skip, an indication why this packet is skipped, otherwise None.
* @param skip_reason If action is Skip, an indication why this packet is skipped, otherwise None.
*/
virtual void TapPacket(const Packet& pkt, PacketAction action, SkipReason skip_reason) = 0;
@ -195,10 +195,10 @@ public:
* Helper to forward a packet to all attached TapAnalyzer instances.
*
* @param pkt The packet.
* @param verdict Whether the packet will be delivered or skipped.
* @param skip_reason If verdict is Skip, should be an indication why this packet is skipped.
* @param action Whether the packet will be delivered or skipped.
* @param skip_reason If action is Skip, should be an indication why this packet is skipped.
*/
void TapPacket(const Packet* pkt, PacketAction verdict = PacketAction::Deliver,
void TapPacket(const Packet* pkt, PacketAction action = PacketAction::Deliver,
SkipReason skip_reason = SkipReason::None) const;
/**