mirror of
https://github.com/zeek/zeek.git
synced 2025-10-14 04:28:20 +00:00
Review usage of Reporter::InternalError, addresses BIT-1045.
Replaced some with InternalWarning or InternalAnalyzerError, the later being a new method which signals the analyzer to not process further input. Some usages I just removed if they didn't make sense or clearly couldn't happen. Also did some minor refactors of related code while reviewing/exploring ways to get rid of InternalError usages. Also, for TCP content file write failures there's a new event: "contents_file_write_failure".
This commit is contained in:
parent
6734260136
commit
b828a6ddc7
51 changed files with 532 additions and 267 deletions
11
src/IP.cc
11
src/IP.cc
|
@ -433,7 +433,10 @@ void IPv6_Hdr_Chain::Init(const struct ip6_hdr* ip6, int total_len,
|
|||
const u_char* hdrs = (const u_char*) ip6;
|
||||
|
||||
if ( total_len < (int)sizeof(struct ip6_hdr) )
|
||||
reporter->InternalError("IPv6_HdrChain::Init with truncated IP header");
|
||||
{
|
||||
reporter->InternalWarning("truncated IP header in IPv6_HdrChain::Init");
|
||||
return;
|
||||
}
|
||||
|
||||
do
|
||||
{
|
||||
|
@ -623,9 +626,11 @@ VectorVal* IPv6_Hdr_Chain::BuildVal() const
|
|||
break;
|
||||
#endif
|
||||
default:
|
||||
reporter->InternalError("IPv6_Hdr_Chain bad header %d", type);
|
||||
break;
|
||||
reporter->InternalWarning("IPv6_Hdr_Chain bad header %d", type);
|
||||
Unref(ext_hdr);
|
||||
continue;
|
||||
}
|
||||
|
||||
rval->Assign(rval->Size(), ext_hdr);
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue