mirror of
https://github.com/zeek/zeek.git
synced 2025-10-05 16:18:19 +00:00
Review usage of Reporter::InternalError, addresses BIT-1045.
Replaced some with InternalWarning or InternalAnalyzerError, the later being a new method which signals the analyzer to not process further input. Some usages I just removed if they didn't make sense or clearly couldn't happen. Also did some minor refactors of related code while reviewing/exploring ways to get rid of InternalError usages. Also, for TCP content file write failures there's a new event: "contents_file_write_failure".
This commit is contained in:
parent
6734260136
commit
b828a6ddc7
51 changed files with 532 additions and 267 deletions
|
@ -294,7 +294,9 @@ bool Value::Read(SerializationFormat* fmt)
|
|||
}
|
||||
|
||||
default:
|
||||
reporter->InternalError("unsupported type %s in Value::Write", type_name(type));
|
||||
reporter->InternalError("unsupported type %s in Value::Read",
|
||||
type_name(type));
|
||||
return false;
|
||||
}
|
||||
|
||||
return false;
|
||||
|
@ -398,7 +400,9 @@ bool Value::Write(SerializationFormat* fmt) const
|
|||
}
|
||||
|
||||
default:
|
||||
reporter->InternalError("unsupported type %s in Value::REad", type_name(type));
|
||||
reporter->InternalError("unsupported type %s in Value::Write",
|
||||
type_name(type));
|
||||
return false;
|
||||
}
|
||||
|
||||
return false;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue